You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kudu.apache.org by gr...@apache.org on 2020/12/23 18:28:31 UTC

[kudu] branch master updated: [thirpdarty] Upgrade to gperftools 2.8.1

This is an automated email from the ASF dual-hosted git repository.

granthenke pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/kudu.git


The following commit(s) were added to refs/heads/master by this push:
     new 2884df1  [thirpdarty] Upgrade to gperftools 2.8.1
2884df1 is described below

commit 2884df180c83b06652f93a6d1b1275ec2ed30f04
Author: Grant Henke <gr...@apache.org>
AuthorDate: Tue Dec 22 13:47:22 2020 -0600

    [thirpdarty] Upgrade to gperftools 2.8.1
    
    gperftools 2.8.0 had a new feature that lead to crashes and corruption
    which was reverted in 2.8.1. This patch upgrades to 2.8.1 to avoid any
    issues.
    
    One of the issues that is fixed via feature revert in 2.8.1 is
    https://github.com/gperftools/gperftools/issues/1204
    
    Change-Id: I69f3405d14c4a853d8c224b8111fef5961ea34dc
    Reviewed-on: http://gerrit.cloudera.org:8080/16897
    Reviewed-by: Bankim Bhavsar <ba...@cloudera.com>
    Reviewed-by: Alexey Serbin <as...@cloudera.com>
    Tested-by: Kudu Jenkins
---
 thirdparty/download-thirdparty.sh             |  1 -
 thirdparty/patches/gperftools-osx-arm64.patch | 21 ---------------------
 thirdparty/vars.sh                            |  2 +-
 3 files changed, 1 insertion(+), 23 deletions(-)

diff --git a/thirdparty/download-thirdparty.sh b/thirdparty/download-thirdparty.sh
index e25ff24..1491c0e 100755
--- a/thirdparty/download-thirdparty.sh
+++ b/thirdparty/download-thirdparty.sh
@@ -199,7 +199,6 @@ fetch_and_patch \
  $GPERFTOOLS_SOURCE \
  $GPERFTOOLS_PATCHLEVEL \
  "patch -p1 < $TP_DIR/patches/gperftools-Replace-namespace-base-with-namespace-tcmalloc.patch" \
- "patch -p1 < $TP_DIR/patches/gperftools-osx-arm64.patch" \
  "autoreconf -fvi"
 
 # NOTE: creating an empty 'third_party/googletest/m4' subdir is a recipe from
diff --git a/thirdparty/patches/gperftools-osx-arm64.patch b/thirdparty/patches/gperftools-osx-arm64.patch
deleted file mode 100644
index 7c4cdec..0000000
--- a/thirdparty/patches/gperftools-osx-arm64.patch
+++ /dev/null
@@ -1,21 +0,0 @@
-From 23f7072ab6bfa5c0d1b45cf1e8d66053c7b738a8 Mon Sep 17 00:00:00 2001
-From: Grant Henke <gr...@gmail.com>
-Date: Thu, 26 Nov 2020 20:56:46 -0600
-Subject: [PATCH] Add OS X arm64 program counter
-
----
- m4/pc_from_ucontext.m4 | 1 +
- 1 file changed, 1 insertion(+)
-
-diff --git a/m4/pc_from_ucontext.m4 b/m4/pc_from_ucontext.m4
-index 0c7ee281..6e8b5d00 100644
---- a/m4/pc_from_ucontext.m4
-+++ b/m4/pc_from_ucontext.m4
-@@ -43,6 +43,7 @@ AC_DEFUN([AC_PC_FROM_UCONTEXT],
-    pc_fields="$pc_fields uc_mcontext->__ss.__rip"      # OS X (>=10.5 [untested])
-    pc_fields="$pc_fields uc_mcontext->ss.srr0"         # OS X (ppc, ppc64 [untested])
-    pc_fields="$pc_fields uc_mcontext->__ss.__srr0"     # OS X (>=10.5 [untested])
-+   pc_fields="$pc_fields uc_mcontext->__ss.__pc"       # OS X (arm64 [untested])
-    pc_field_found=false
-    for pc_field in $pc_fields; do
-      if ! $pc_field_found; then
\ No newline at end of file
diff --git a/thirdparty/vars.sh b/thirdparty/vars.sh
index 1f279f9..6b8eab8 100644
--- a/thirdparty/vars.sh
+++ b/thirdparty/vars.sh
@@ -50,7 +50,7 @@ GMOCK_VERSION=1.8.0
 GMOCK_NAME=googletest-release-$GMOCK_VERSION
 GMOCK_SOURCE=$TP_SOURCE_DIR/$GMOCK_NAME
 
-GPERFTOOLS_VERSION=2.8
+GPERFTOOLS_VERSION=2.8.1
 GPERFTOOLS_NAME=gperftools-$GPERFTOOLS_VERSION
 GPERFTOOLS_SOURCE=$TP_SOURCE_DIR/$GPERFTOOLS_NAME