You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2018/09/22 15:56:01 UTC

[GitHub] odracci commented on a change in pull request #3683: [AIRFLOW-2770] kubernetes: add support for dag folder in the docker i…

odracci commented on a change in pull request #3683: [AIRFLOW-2770] kubernetes: add support for dag folder in the docker i…
URL: https://github.com/apache/incubator-airflow/pull/3683#discussion_r219674969
 
 

 ##########
 File path: airflow/contrib/executors/kubernetes_executor.py
 ##########
 @@ -195,10 +199,12 @@ def __init__(self):
         self._validate()
 
     def _validate(self):
-        if not self.dags_volume_claim and (not self.git_repo or not self.git_branch):
+        if not self.dags_volume_claim and not self.dags_in_docker \
+                and (not self.git_repo or not self.git_branch):
 
 Review comment:
   this would collide with the changes in https://github.com/apache/incubator-airflow/pull/3770/files#diff-b1d8d65aeaa7d031dfe5b197d6c5aa69L200

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services