[jira] [Commented] (DRILL-6581) Improve C++ Client SSL Implementation

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/DRILL-6581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16535381#comment-16535381 ] 

ASF GitHub Bot commented on DRILL-6581:
---------------------------------------

superbstreak opened a new pull request #1366: [DRILL-6581] C++ Client SSL Implementation Fixes/Improvements
URL: https://github.com/apache/drill/pull/1366
 
 
   - Fix: Hostname verification doesnt function as expected. 
          > Host and port passed in to the callback are always empty. Parsing the connection string before we use the host name.
          > Connection string port (31010) is not required for the hostname verification.
   - Fix: Certificate load verification exceptions are swallowed and not propagated.
   - Improvement: SSL V3 is not disabled.
          > Disabled SSLv2 and SSLv3.
   - Improvement: Hostname verification will throw the same error message as certificate exception.  
          > Separated them to allow better user error handling/debugging.
   - Improvement: Create individual error messages to allow error handling of the application using the client and follows the standard of the rest of the errors

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Improve C++ Client SSL Implementation
> -------------------------------------
>
>                 Key: DRILL-6581
>                 URL: https://issues.apache.org/jira/browse/DRILL-6581
>             Project: Apache Drill
>          Issue Type: Improvement
>          Components: Client - C++
>    Affects Versions: 1.12.0
>            Reporter: Rob Wu
>            Priority: Major
>
> # Fix: Hostname verification doesnt function as expected: Host and port in the ssl hostname verification callback is always empty.
>  # Fix: Certificate load verification exceptions are swallowed and not propagated.
>  # Improvement: SSL V3 is not disabled.
>  # Improvement: Hostname verification failure exception is the same as other certificate verification failures, we should separate them
>  # Improvement: Create individual error messages to allow error handling of the application using the client and follows the standard of the rest of the errors



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)