[jira] [Commented] (CALCITE-705) AvaticaStatement execute method to support DML

["YeongWei (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CALCITE-705?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14568478#comment-14568478 ] 

YeongWei commented on CALCITE-705:
----------------------------------

Hi [~julianhyde]

I have updated the implementation and the current work-in-progress can be found at,

https://github.com/yeongwei/incubator-calcite/commit/9807c4a68429040a564f18bdfb1c9d9d2497b40c?diff=split

Highlights,
1) Signature as a class field with AvaticaStatement
2) StatementType enum within Meta.java and UPDATE_CAPABLE list within StatementType Object
3) IsUpdateCapable to handle DML response for both LOCAL and REMOTE
4) Implemented only the INSERT

UnitTests,
1) LOCAL Statement INSERT
JdbcFrontLinqBackTest#testInsert3
2) LOCAL PreparedStatement INSERT
JdbcFrontLinqBackTest#testPreparedStatementInsert
3) REMOTE Statement INSERT
CalciteRemoteDriverTest#testInsert
4) REMOTE PreparedStatement INSERT
CalciteRemoteDriverTest#testRemotePreparedStatementInsert

Let me know you comments.

Currently will continue to work on the UPDATE and DELETE that should piggy back on the implementation shown above 

Thanks!


> AvaticaStatement execute method to support DML
> ----------------------------------------------
>
>                 Key: CALCITE-705
>                 URL: https://issues.apache.org/jira/browse/CALCITE-705
>             Project: Calcite
>          Issue Type: New Feature
>            Reporter: YeongWei
>            Assignee: Julian Hyde
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)