You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@burr.apache.org by "elijahbenizzy (via GitHub)" <gi...@apache.org> on 2026/10/04 20:38:11 UTC
[PR] fix(tracking): validate identifiers and keep server paths inside the storage directory [burr]
elijahbenizzy opened a new pull request, #948:
URL: https://github.com/apache/burr/pull/948
Carries forward #795 by @andreahlert with his commit intact, and shares the identifier rule with the tracking client (#946).
- Project and app identifiers in tracking server requests are validated against the same allowlist the client uses; invalid ones return HTTP 400.
- Paths the server builds are resolved and kept inside the configured storage directory.
- `python -m burr.tracking.server.run` binds to `127.0.0.1` by default, overridable with `BURR_SERVER_HOST`, matching what the `burr` CLI already does. The CLI help and module docstring note that the server has no built-in authentication.
23 tests added. Merge before #944, which documents this behavior.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@burr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(tracking): validate identifiers and keep server paths inside the storage directory [burr]
Posted by "elijahbenizzy (via GitHub)" <gi...@apache.org>.
elijahbenizzy commented on PR #948:
URL: https://github.com/apache/burr/pull/948#issuecomment-6235632729
@skrawcz done: (1) the four fixed filenames are containment-checked individually, with a symlink test per file; (2) demo routers are opt-in via `BURR_SERVER_DEMOS`, which only `burr-demo` sets, with tests for both states and the CLI wiring; (3) same identifier helper as #946, control characters rejected. The two branches merge cleanly in either order; I ran `tests/tracking` on the merged tree. @sangkyoonnam if you want another pass, this is the state to test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@burr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(tracking): validate identifiers and keep server paths inside the storage directory [burr]
Posted by "skrawcz (via GitHub)" <gi...@apache.org>.
skrawcz commented on PR #948:
URL: https://github.com/apache/burr/pull/948#issuecomment-6052539265
Two remaining hardening items before merging:
1. `_safe_join()` currently validates only the application directory in `get_application_logs()`. The subsequently opened `graph.json`, `log.jsonl`, `metadata.json`, and `children.jsonl` paths are built with plain `os.path.join()`. Please apply containment checks to each final file path as well, and add tests where each fixed filename is a symlink outside the configured storage directory.
2. The tracking server still mounts writable demo routers by default, and those demos use a separate hardcoded `~/.burr` tracking client rather than the backend’s configured path. Please make demo routes explicitly opt-in, or at minimum document and test this separation. A production-capable tracking server should not expose mutation demos by default.
Also incorporate the identifier-regex fix from #946: use `fullmatch()` or an end anchor that does not accept a trailing newline.
I view file-level symlink handling as defense-in-depth because the storage directory is operator-controlled, but if this PR claims that every server path remains inside the configured storage directory, final file paths need to satisfy that claim too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@burr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(tracking): validate identifiers and keep server paths inside the storage directory [burr]
Posted by "github-actions[bot] (via GitHub) via notifications" <no...@burr.apache.org>.
github-actions[bot] commented on PR #948:
URL: https://github.com/apache/burr/pull/948#issuecomment-6573545945
This PR has been inactive for 15 days after receiving review feedback.
Converting to draft.
Please mark it as ready for review when you have addressed the comments.
If no activity occurs within 90 days, it will be closed automatically.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@burr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org