You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by or...@apache.org on 2023/06/20 09:10:33 UTC

[camel] 01/02: (chores) camel-openapi-java: removed unused method parameters

This is an automated email from the ASF dual-hosted git repository.

orpiske pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/camel.git

commit cef11a2dbdbcb81b2084074657ae4178907c3ab1
Author: Otavio R. Piske <an...@gmail.com>
AuthorDate: Tue Jun 20 09:24:26 2023 +0200

    (chores) camel-openapi-java: removed unused method parameters
    
    Signed-off-by: Otavio R. Piske <an...@gmail.com>
---
 .../src/main/java/org/apache/camel/openapi/OpenAPI3to2.java           | 4 ++--
 .../java/org/apache/camel/openapi/OpenApiRestProducerFactory.java     | 4 ++--
 .../src/main/java/org/apache/camel/openapi/RestModelConverters.java   | 4 ++--
 .../java/org/apache/camel/openapi/OpenApiRestProducerFactoryTest.java | 4 ++--
 4 files changed, 8 insertions(+), 8 deletions(-)

diff --git a/components/camel-openapi-java/src/main/java/org/apache/camel/openapi/OpenAPI3to2.java b/components/camel-openapi-java/src/main/java/org/apache/camel/openapi/OpenAPI3to2.java
index 34394aba3d4..a699555c863 100644
--- a/components/camel-openapi-java/src/main/java/org/apache/camel/openapi/OpenAPI3to2.java
+++ b/components/camel-openapi-java/src/main/java/org/apache/camel/openapi/OpenAPI3to2.java
@@ -107,7 +107,7 @@ public class OpenAPI3to2 {
             }
         }
         if (openApi3.getComponents() != null && openApi3.getComponents().getSecuritySchemes() != null) {
-            convertSecurityDefinitions(openApi2, openApi3.getComponents().getSecuritySchemes());
+            convertSecurityDefinitions(openApi3.getComponents().getSecuritySchemes());
         }
         if (openApi3.getSecurity() != null) {
             for (SecurityRequirement sr : openApi3.getSecurity()) {
@@ -124,7 +124,7 @@ public class OpenAPI3to2 {
         return sreq;
     }
 
-    private void convertSecurityDefinitions(Swagger openApi22, Map<String, SecurityScheme> securitySchemes) {
+    private void convertSecurityDefinitions(Map<String, SecurityScheme> securitySchemes) {
         for (Map.Entry<String, SecurityScheme> entry : securitySchemes.entrySet()) {
             openApi2.addSecurityDefinition(entry.getKey(), convertSecurityScheme(entry.getValue()));
         }
diff --git a/components/camel-openapi-java/src/main/java/org/apache/camel/openapi/OpenApiRestProducerFactory.java b/components/camel-openapi-java/src/main/java/org/apache/camel/openapi/OpenApiRestProducerFactory.java
index 3c5dc57c251..d938148d0a8 100644
--- a/components/camel-openapi-java/src/main/java/org/apache/camel/openapi/OpenApiRestProducerFactory.java
+++ b/components/camel-openapi-java/src/main/java/org/apache/camel/openapi/OpenApiRestProducerFactory.java
@@ -59,7 +59,7 @@ public class OpenApiRestProducerFactory implements RestProducerFactory {
             path = "/" + path;
         }
 
-        OpenAPI openApi = loadOpenApiModel(camelContext, apiDoc);
+        OpenAPI openApi = loadOpenApiModel(apiDoc);
         Operation operation = getOpenApiOperation(openApi, verb, path);
         if (operation == null) {
             throw new IllegalArgumentException("OpenApi api-doc does not contain operation for " + verb + ":" + path);
@@ -87,7 +87,7 @@ public class OpenApiRestProducerFactory implements RestProducerFactory {
                 produces, consumes, componentName, parameters);
     }
 
-    OpenAPI loadOpenApiModel(CamelContext camelContext, String apiDoc) throws Exception {
+    OpenAPI loadOpenApiModel(String apiDoc) throws Exception {
         final OpenAPIParser openApiParser = new OpenAPIParser();
         final SwaggerParseResult openApi = openApiParser.readLocation(apiDoc, null, null);
 
diff --git a/components/camel-openapi-java/src/main/java/org/apache/camel/openapi/RestModelConverters.java b/components/camel-openapi-java/src/main/java/org/apache/camel/openapi/RestModelConverters.java
index 2687564f2ce..a02caa8bd65 100644
--- a/components/camel-openapi-java/src/main/java/org/apache/camel/openapi/RestModelConverters.java
+++ b/components/camel-openapi-java/src/main/java/org/apache/camel/openapi/RestModelConverters.java
@@ -60,11 +60,11 @@ public class RestModelConverters {
             // File is a special type in OAS2 / OAS3 (no model)
             return null;
         } else {
-            return readClassOpenApi3(oasDocument, clazz);
+            return readClassOpenApi3(clazz);
         }
     }
 
-    private List<? extends Schema> readClassOpenApi3(OpenAPI oasDocument, Class<?> clazz) {
+    private List<? extends Schema> readClassOpenApi3(Class<?> clazz) {
         String name = clazz.getName();
         if (!name.contains(".")) {
             return null;
diff --git a/components/camel-openapi-java/src/test/java/org/apache/camel/openapi/OpenApiRestProducerFactoryTest.java b/components/camel-openapi-java/src/test/java/org/apache/camel/openapi/OpenApiRestProducerFactoryTest.java
index 18d7f4b315a..ec33ed0b349 100644
--- a/components/camel-openapi-java/src/test/java/org/apache/camel/openapi/OpenApiRestProducerFactoryTest.java
+++ b/components/camel-openapi-java/src/test/java/org/apache/camel/openapi/OpenApiRestProducerFactoryTest.java
@@ -27,13 +27,13 @@ public class OpenApiRestProducerFactoryTest {
     public void shouldLoadOpenApiPetStoreModel() throws Exception {
         OpenApiRestProducerFactory factory = new OpenApiRestProducerFactory();
 
-        assertNotNull(factory.loadOpenApiModel(new DefaultCamelContext(), "petstore.json"));
+        assertNotNull(factory.loadOpenApiModel("petstore.json"));
     }
 
     @Test
     public void shouldLoadOpenApiPetStoreModelV3() throws Exception {
         OpenApiRestProducerFactory factory = new OpenApiRestProducerFactory();
 
-        assertNotNull(factory.loadOpenApiModel(new DefaultCamelContext(), "petstore-v3.json"));
+        assertNotNull(factory.loadOpenApiModel( "petstore-v3.json"));
     }
 }