You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2021/04/08 07:48:36 UTC

[GitHub] [rocketmq] juliuszhang opened a new pull request #2788: fix typo in design.md

juliuszhang opened a new pull request #2788:
URL: https://github.com/apache/rocketmq/pull/2788


   fix typo in design.md
   
   
   **Make sure set the target branch to `develop`**
   
   ## What is the purpose of the change
   
   fix typo in design.md
   
   ## Brief changelog
   
   fix typo in design.md
   
   ## Verifying this change
   
   XXXX
   
   Follow this checklist to help us incorporate your contribution quickly and easily. Notice, `it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR`.
   
   - [x] Make sure there is a [Github issue](https://github.com/apache/rocketmq/issues) filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue. 
   - [x] Format the pull request title like `[ISSUE #123] Fix UnknownException when host config not exist`. Each commit in the pull request should have a meaningful subject line and body.
   - [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
   - [x] Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in [test module](https://github.com/apache/rocketmq/tree/master/test).
   - [x] Run `mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle` to make sure basic checks pass. Run `mvn clean install -DskipITs` to make sure unit-test pass. Run `mvn clean test-compile failsafe:integration-test`  to make sure integration-test pass.
   - [ ] If this contribution is large, please file an [Apache Individual Contributor License Agreement](http://www.apache.org/licenses/#clas).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq] coveralls commented on pull request #2788: fix typo in design.md

Posted by GitBox <gi...@apache.org>.
coveralls commented on pull request #2788:
URL: https://github.com/apache/rocketmq/pull/2788#issuecomment-815553088


   
   [![Coverage Status](https://coveralls.io/builds/38633173/badge)](https://coveralls.io/builds/38633173)
   
   Coverage increased (+0.02%) to 51.855% when pulling **2e3da67162f4976282921dd4a712f6d9ba98e95a on juliuszhang:master** into **b4240d5cea8d001c21b9c0d73f5aa700fcd0d568 on apache:master**.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq] vongosling closed pull request #2788: [ISSUE #XXX] Fix typo in design.md

Posted by GitBox <gi...@apache.org>.
vongosling closed pull request #2788:
URL: https://github.com/apache/rocketmq/pull/2788


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq] RongtongJin commented on pull request #2788: [ISSUE #XXX] Fix typo in design.md

Posted by GitBox <gi...@apache.org>.
RongtongJin commented on pull request #2788:
URL: https://github.com/apache/rocketmq/pull/2788#issuecomment-817431528


   Plz create an issue before you submit a pull request and change the target branch to develop.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq] vongosling commented on pull request #2788: [ISSUE #XXX] Fix typo in design.md

Posted by GitBox <gi...@apache.org>.
vongosling commented on pull request #2788:
URL: https://github.com/apache/rocketmq/pull/2788#issuecomment-843738068


   Long time no ack. so I'v fixed this error. thanks @juliuszhang There is only one step for merging. you could follow the guild as the community contribution next time.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org