[GitHub] [dolphinscheduler] SbloodyS commented on a diff in pull request #11467: [improve] Support re running historical version workflow

[GitBox <gi...@apache.org>]

SbloodyS commented on code in PR #11467:
URL: https://github.com/apache/dolphinscheduler/pull/11467#discussion_r945380417


##########
dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/impl/ExecutorServiceImpl.java:
##########
@@ -274,10 +274,7 @@ public Map<String, Object> checkProcessDefinitionValid(long projectCode, Process
         if (processDefinition == null || projectCode != processDefinition.getProjectCode()) {
             // check process definition exists
             putMsg(result, Status.PROCESS_DEFINE_NOT_EXIST, String.valueOf(processDefineCode));
-        } else if (processDefinition.getReleaseState() != ReleaseState.ONLINE) {
-            // check process definition online
-            putMsg(result, Status.PROCESS_DEFINE_NOT_RELEASE, String.valueOf(processDefineCode), version);
-        } else if (!checkSubProcessDefinitionValid(processDefinition)) {

Review Comment:
   It's not a good idea to change it since this method is used in more than one place.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org