[jira] [Updated] (KAFKA-346) Don't call commitOffsets() during rebalance

["Peter Romianowski (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/KAFKA-346?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Peter Romianowski updated KAFKA-346:
------------------------------------

    Attachment: KAFKA-346.patch

Added a patch against trunk. In order to compile KAFKA-345 has to be applied.
                
> Don't call commitOffsets() during rebalance
> -------------------------------------------
>
>                 Key: KAFKA-346
>                 URL: https://issues.apache.org/jira/browse/KAFKA-346
>             Project: Kafka
>          Issue Type: Improvement
>          Components: core
>    Affects Versions: 0.7, 0.8, 0.7.1
>            Reporter: Peter Romianowski
>         Attachments: KAFKA-346.patch
>
>
> A sample use-case
> If I read the source correctly then offsets can be committed at any
> time (whenever there is a change in consumer or broker zk registry).
> Our application doesn't use auto-commit in order to batch some
> messages together, process them and if everything went fine, we call
> commitOffsets(). If, for any reason, the processing of messages does
> not succeed, we rely on Kafka's promise to re-deliver the messages.
> But if ZKRebalancerListener triggers a rebalance before our "batch" of
> messages is full, then offsets will be committed even if the messages
> have not been processed yet by our application. So if then processing
> of these messages fails, we basically lost them, right?
> (See discussion at http://www.mail-archive.com/kafka-users@incubator.apache.org/msg01415.html)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira