You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@htrace.apache.org by "Colin Patrick McCabe (JIRA)" <ji...@apache.org> on 2015/03/01 17:49:04 UTC

[jira] [Commented] (HTRACE-127) fix ./build/htrace dumpAll

    [ https://issues.apache.org/jira/browse/HTRACE-127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14342322#comment-14342322 ] 

Colin Patrick McCabe commented on HTRACE-127:
---------------------------------------------

I also wrapped the File in a bufio.Writer.  This is the preferred way to write to a file in golang most of the time, since if you don't use a bufio.Writer, every write generates a syscall.

> fix ./build/htrace dumpAll
> --------------------------
>
>                 Key: HTRACE-127
>                 URL: https://issues.apache.org/jira/browse/HTRACE-127
>             Project: HTrace
>          Issue Type: Bug
>    Affects Versions: 3.2.0
>            Reporter: Colin Patrick McCabe
>            Assignee: Colin Patrick McCabe
>         Attachments: HTRACE-127.002.patch
>
>
> Fix {{./build/htrace dumpAll}}.  An inverted conditional means that it currently doesn't dump any spans to the provided file.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)