You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2021/01/28 09:20:51 UTC
[GitHub] [flink] SteNicholas opened a new pull request #14792: [FLINK-21172][canal][json] canal-json format include es field
SteNicholas opened a new pull request #14792:
URL: https://github.com/apache/flink/pull/14792
## What is the purpose of the change
*Metadata column of `CanalJsonDecodingFormat` doesn't support to extract the `es` field of Canal JSON record, which field extracts from MySQL binlog represent for the row data real change time in MySQL. The `event-timestamp` metadata column expresses the event time.*
## Brief change log
- *`CanalJsonDecodingFormat` adds `event-timestamp` metadata column for the `es` field of Canal JSON record.*
## Verifying this change
- *`CanalJsonSerDeSchemaTest` adds the validation to verify whether the `event-timestamp` metadata column value is equal to the value of `es` field.*
- *`KafkaChangelogTableITCase` adds the `event-timestamp` metadata column in the DDL of Kafka source table to verify the `event-timestamp` metadata column could be used as event time.*
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (yes / **no**)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**)
- The serializers: (yes / **no** / don't know)
- The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (yes / **no** / don't know)
- The S3 file system connector: (yes / **no** / don't know)
## Documentation
- Does this pull request introduce a new feature? (yes / **no**)
- If yes, how is the feature documented? (**not applicable** / docs / JavaDocs / not documented)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14792: [FLINK-21172][canal][json] canal-json format include es field
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14792:
URL: https://github.com/apache/flink/pull/14792#issuecomment-768926136
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "807e88581b52e9bda62e19f87e42516173b71db4",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12598",
"triggerID" : "807e88581b52e9bda62e19f87e42516173b71db4",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 807e88581b52e9bda62e19f87e42516173b71db4 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12598)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14792: [FLINK-21172][canal][json] canal-json format include es field
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14792:
URL: https://github.com/apache/flink/pull/14792#issuecomment-768918202
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit c7bea181135ec235cb6550fad13c41cdf93b103f (Fri May 28 08:15:53 UTC 2021)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14792: [FLINK-21172][canal][json] canal-json format include es field
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14792:
URL: https://github.com/apache/flink/pull/14792#issuecomment-768926136
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "807e88581b52e9bda62e19f87e42516173b71db4",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12598",
"triggerID" : "807e88581b52e9bda62e19f87e42516173b71db4",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 807e88581b52e9bda62e19f87e42516173b71db4 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12598)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] SteNicholas commented on pull request #14792: [FLINK-21172][canal][json] canal-json format include es field
Posted by GitBox <gi...@apache.org>.
SteNicholas commented on pull request #14792:
URL: https://github.com/apache/flink/pull/14792#issuecomment-769530715
@wuchong , the CI result is successful. If you are available, please help to review this pull request.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14792: [FLINK-21172][canal][json] canal-json format include es field
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14792:
URL: https://github.com/apache/flink/pull/14792#issuecomment-768926136
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "807e88581b52e9bda62e19f87e42516173b71db4",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12598",
"triggerID" : "807e88581b52e9bda62e19f87e42516173b71db4",
"triggerType" : "PUSH"
}, {
"hash" : "c7bea181135ec235cb6550fad13c41cdf93b103f",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12735",
"triggerID" : "c7bea181135ec235cb6550fad13c41cdf93b103f",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 807e88581b52e9bda62e19f87e42516173b71db4 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12598)
* c7bea181135ec235cb6550fad13c41cdf93b103f Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12735)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14792: [FLINK-21172][canal][json] canal-json format include es field
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14792:
URL: https://github.com/apache/flink/pull/14792#issuecomment-768926136
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "807e88581b52e9bda62e19f87e42516173b71db4",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12598",
"triggerID" : "807e88581b52e9bda62e19f87e42516173b71db4",
"triggerType" : "PUSH"
}, {
"hash" : "c7bea181135ec235cb6550fad13c41cdf93b103f",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "c7bea181135ec235cb6550fad13c41cdf93b103f",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 807e88581b52e9bda62e19f87e42516173b71db4 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12598)
* c7bea181135ec235cb6550fad13c41cdf93b103f UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #14792: [FLINK-21172][canal][json] canal-json format include es field
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #14792:
URL: https://github.com/apache/flink/pull/14792#issuecomment-768926136
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "807e88581b52e9bda62e19f87e42516173b71db4",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "807e88581b52e9bda62e19f87e42516173b71db4",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 807e88581b52e9bda62e19f87e42516173b71db4 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wuchong commented on a change in pull request #14792: [FLINK-21172][canal][json] canal-json format include es field
Posted by GitBox <gi...@apache.org>.
wuchong commented on a change in pull request #14792:
URL: https://github.com/apache/flink/pull/14792#discussion_r567671294
##########
File path: docs/dev/table/connectors/formats/canal.zh.md
##########
@@ -189,6 +189,12 @@ metadata fields for its value format.
<td>The timestamp at which the connector processed the event. Corresponds to the <code>ts</code>
field in the Canal record.</td>
</tr>
+ <tr>
+ <td><code>event-timestamp</code></td>
+ <td><code>TIMESTAMP(3) WITH LOCAL TIME ZONE NULL</code></td>
+ <td>The timestamp at which the connector produced the event. Corresponds to the <code>es</code>
Review comment:
This description is misleading, because "the connector produced the event" sounds "ingetsion time". The event and the `es` is not produced by the connector, but the binlog dump of mysql server. Maybe we can say:
```
The timestamp when the corresponding change was executed in MySQL server.
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #14792: [FLINK-21172][canal][json] canal-json format include es field
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #14792:
URL: https://github.com/apache/flink/pull/14792#issuecomment-768918202
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 807e88581b52e9bda62e19f87e42516173b71db4 (Thu Jan 28 09:22:54 UTC 2021)
✅no warnings
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wuchong merged pull request #14792: [FLINK-21172][canal][json] canal-json format include es field
Posted by GitBox <gi...@apache.org>.
wuchong merged pull request #14792:
URL: https://github.com/apache/flink/pull/14792
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wuchong merged pull request #14792: [FLINK-21172][canal][json] canal-json format include es field
Posted by GitBox <gi...@apache.org>.
wuchong merged pull request #14792:
URL: https://github.com/apache/flink/pull/14792
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14792: [FLINK-21172][canal][json] canal-json format include es field
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14792:
URL: https://github.com/apache/flink/pull/14792#issuecomment-768926136
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "807e88581b52e9bda62e19f87e42516173b71db4",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12598",
"triggerID" : "807e88581b52e9bda62e19f87e42516173b71db4",
"triggerType" : "PUSH"
}, {
"hash" : "c7bea181135ec235cb6550fad13c41cdf93b103f",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12735",
"triggerID" : "c7bea181135ec235cb6550fad13c41cdf93b103f",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* c7bea181135ec235cb6550fad13c41cdf93b103f Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12735)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org