You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2020/04/14 14:31:10 UTC
[GitHub] [nifi] jfrazee commented on a change in pull request #4207:
NIFI-7203 Add ZooKeeper client and server TLS
jfrazee commented on a change in pull request #4207: NIFI-7203 Add ZooKeeper client and server TLS
URL: https://github.com/apache/nifi/pull/4207#discussion_r408182939
##########
File path: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core/src/main/java/org/apache/nifi/controller/state/server/ZooKeeperStateServer.java
##########
@@ -136,7 +167,15 @@ private void startDistributed() throws IOException {
quorumPeer.setInitLimit(quorumPeerConfig.getInitLimit());
quorumPeer.setSyncLimit(quorumPeerConfig.getSyncLimit());
quorumPeer.setQuorumVerifier(quorumPeerConfig.getQuorumVerifier(), false);
- quorumPeer.setCnxnFactory(connectionFactory);
+
+ if (connectionFactory != null) {
+ quorumPeer.setCnxnFactory(connectionFactory);
+ }
+
+ if (secureConnectionFactory != null) {
+ quorumPeer.setCnxnFactory(secureConnectionFactory);
Review comment:
Yup. Funny, since the standalone state server calls `.startup()` / `.shutdown()` directly on the connection factories this never surfaced.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services