You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@mesos.apache.org by Dragos Schebesch via Review Board <no...@reviews.apache.org> on 2018/06/08 12:07:44 UTC

Review Request 67504: Added helper for posting the result of a build

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67504/
-----------------------------------------------------------

Review request for mesos and Andrew Schwartzmeyer.


Repository: mesos


Description
-------

Added helper for posting the result of a build


Diffs (updated)
-----

  support/python3/post-build-result.py PRE-CREATION 


Diff: https://reviews.apache.org/r/67504/diff/1/


Testing
-------


Thanks,

Dragos Schebesch

Re: Review Request 67504: Added helper for posting the result of a build

Posted by Armand Grillet <ag...@mesosphere.io>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67504/#review204672
-----------------------------------------------------------



Regarding the commit: its message should be more descriptive regarding the reasons behind this new support script and the Testing Done part should be filled with at least some tests or the fact that tests can be read later in the chain.


support/python3/post-build-result.py
Lines 18 (patched)
<https://reviews.apache.org/r/67504/#comment287276>

    Missing docstring.



support/python3/post-build-result.py
Lines 29 (patched)
<https://reviews.apache.org/r/67504/#comment287277>

    Missing docstring.



support/python3/post-build-result.py
Lines 43 (patched)
<https://reviews.apache.org/r/67504/#comment287275>

    Wrong continued indentation.



support/python3/post-build-result.py
Lines 53 (patched)
<https://reviews.apache.org/r/67504/#comment287278>

    Having [] as argument is dangerous. The problem with a mutable default argument is that it will be shared between all invocations of the function. This should be replaced by:
    ```
    def get_build_message(message, outputs_url, logs_urls=None, applied_reviews=None,
                          failed_command=None):
        if logs_urls is None:
            logs_urls = []
        if applied_reviews is None:
            applied_reviews = []
    ```



support/python3/post-build-result.py
Lines 55 (patched)
<https://reviews.apache.org/r/67504/#comment287280>

    Missing docstring.



support/python3/post-build-result.py
Lines 81 (patched)
<https://reviews.apache.org/r/67504/#comment287279>

    Missing docstring.


- Armand Grillet


On June 8, 2018, 12:07 p.m., Dragos Schebesch wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67504/
> -----------------------------------------------------------
> 
> (Updated June 8, 2018, 12:07 p.m.)
> 
> 
> Review request for mesos and Andrew Schwartzmeyer.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added helper for posting the result of a build
> 
> 
> Diffs
> -----
> 
>   support/python3/post-build-result.py PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/67504/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Dragos Schebesch
> 
>

Re: Review Request 67504: Added support script to post build results.

Posted by Dragos Schebesch via Review Board <no...@reviews.apache.org>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67504/#review206240
-----------------------------------------------------------



dummy

All the build artifacts available at: http://dummy.com/artifact

- Dragos Schebesch


On July 18, 2018, 8:50 a.m., Dragos Schebesch wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67504/
> -----------------------------------------------------------
> 
> (Updated July 18, 2018, 8:50 a.m.)
> 
> 
> Review request for mesos, Andrew Schwartzmeyer and Armand Grillet.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added support script to post build results.
> 
> 
> Diffs
> -----
> 
>   support/python3/post-build-result.py PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/67504/diff/4/
> 
> 
> Testing
> -------
> 
> Tests have been done later in the chain.
> 
> 
> Thanks,
> 
> Dragos Schebesch
> 
>

Re: Review Request 67504: Added support script to post build results.

Posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67504/#review207243
-----------------------------------------------------------


Ship it!




Ship It!

- Andrew Schwartzmeyer


On Aug. 7, 2018, 10:37 a.m., Dragos Schebesch wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67504/
> -----------------------------------------------------------
> 
> (Updated Aug. 7, 2018, 10:37 a.m.)
> 
> 
> Review request for mesos, Andrew Schwartzmeyer and Armand Grillet.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added support script to post build results.
> 
> 
> Diffs
> -----
> 
>   support/python3/post-build-result.py PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/67504/diff/5/
> 
> 
> Testing
> -------
> 
> Sample test run that can be seen on this review request:
> ```
> ./python3/post-build-result.py -r 67504 -u <user> -p <password> -m 'dummy' -o http://dummy.com/artifact
> Posting to review request: https://reviews.apache.org/r/67504
> dummy
> 
> All the build artifacts available at: http://dummy.com/artifact
> ```
> 
> 
> Thanks,
> 
> Dragos Schebesch
> 
>

Re: Review Request 67504: Added support script to post build results.

Posted by Dragos Schebesch via Review Board <no...@reviews.apache.org>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67504/
-----------------------------------------------------------

(Updated Aug. 7, 2018, 5:37 p.m.)


Review request for mesos, Andrew Schwartzmeyer and Armand Grillet.


Repository: mesos


Description
-------

Added support script to post build results.


Diffs (updated)
-----

  support/python3/post-build-result.py PRE-CREATION 


Diff: https://reviews.apache.org/r/67504/diff/5/

Changes: https://reviews.apache.org/r/67504/diff/4-5/


Testing
-------

Sample test run that can be seen on this review request:
```
./python3/post-build-result.py -r 67504 -u <user> -p <password> -m 'dummy' -o http://dummy.com/artifact
Posting to review request: https://reviews.apache.org/r/67504
dummy

All the build artifacts available at: http://dummy.com/artifact
```


Thanks,

Dragos Schebesch

Re: Review Request 67504: Added support script to post build results.

Posted by Armand Grillet <ag...@mesosphere.io>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67504/#review206905
-----------------------------------------------------------




support/python3/post-build-result.py
Lines 1 (patched)
<https://reviews.apache.org/r/67504/#comment290030>

    Should be `python3`.


- Armand Grillet


On July 19, 2018, 3:39 p.m., Dragos Schebesch wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67504/
> -----------------------------------------------------------
> 
> (Updated July 19, 2018, 3:39 p.m.)
> 
> 
> Review request for mesos, Andrew Schwartzmeyer and Armand Grillet.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added support script to post build results.
> 
> 
> Diffs
> -----
> 
>   support/python3/post-build-result.py PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/67504/diff/4/
> 
> 
> Testing
> -------
> 
> Sample test run that can be seen on this review request:
> ```
> ./python3/post-build-result.py -r 67504 -u <user> -p <password> -m 'dummy' -o http://dummy.com/artifact
> Posting to review request: https://reviews.apache.org/r/67504
> dummy
> 
> All the build artifacts available at: http://dummy.com/artifact
> ```
> 
> 
> Thanks,
> 
> Dragos Schebesch
> 
>

Re: Review Request 67504: Added support script to post build results.

Posted by Dragos Schebesch via Review Board <no...@reviews.apache.org>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67504/
-----------------------------------------------------------

(Updated July 19, 2018, 3:39 p.m.)


Review request for mesos, Andrew Schwartzmeyer and Armand Grillet.


Repository: mesos


Description
-------

Added support script to post build results.


Diffs
-----

  support/python3/post-build-result.py PRE-CREATION 


Diff: https://reviews.apache.org/r/67504/diff/4/


Testing (updated)
-------

Sample test run that can be seen on this review request:
```
./python3/post-build-result.py -r 67504 -u <user> -p <password> -m 'dummy' -o http://dummy.com/artifact
Posting to review request: https://reviews.apache.org/r/67504
dummy

All the build artifacts available at: http://dummy.com/artifact
```


Thanks,

Dragos Schebesch

Re: Review Request 67504: Added support script to post build results.

Posted by Dragos Schebesch via Review Board <no...@reviews.apache.org>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67504/
-----------------------------------------------------------

(Updated July 18, 2018, 8:50 a.m.)


Review request for mesos, Andrew Schwartzmeyer and Armand Grillet.


Summary (updated)
-----------------

Added support script to post build results.


Repository: mesos


Description (updated)
-------

Added support script to post build results.


Diffs (updated)
-----

  support/python3/post-build-result.py PRE-CREATION 


Diff: https://reviews.apache.org/r/67504/diff/4/

Changes: https://reviews.apache.org/r/67504/diff/3-4/


Testing
-------

Tests have been done later in the chain.


Thanks,

Dragos Schebesch

Re: Review Request 67504: Added helper for posting the result of a build.

Posted by Dragos Schebesch via Review Board <no...@reviews.apache.org>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67504/
-----------------------------------------------------------

(Updated July 11, 2018, 11:54 a.m.)


Review request for mesos, Andrew Schwartzmeyer and Armand Grillet.


Summary (updated)
-----------------

Added helper for posting the result of a build.


Repository: mesos


Description (updated)
-------

Added helper for posting the result of a build.


Diffs (updated)
-----

  support/python3/post-build-result.py PRE-CREATION 


Diff: https://reviews.apache.org/r/67504/diff/3/

Changes: https://reviews.apache.org/r/67504/diff/2-3/


Testing (updated)
-------

Tests have been done later in the chain.


Thanks,

Dragos Schebesch

Re: Review Request 67504: Added helper for posting the result of a build

Posted by Armand Grillet <ag...@mesosphere.io>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67504/#review205906
-----------------------------------------------------------



The commit message should be edited to finish with a period and the Testing Done part should be filled even if it's just to say that tests have been done later in the chain.


support/python3/post-build-result.py
Lines 20 (patched)
<https://reviews.apache.org/r/67504/#comment288808>

    Missing period.



support/python3/post-build-result.py
Lines 33 (patched)
<https://reviews.apache.org/r/67504/#comment288809>

    Missing period.



support/python3/post-build-result.py
Lines 47 (patched)
<https://reviews.apache.org/r/67504/#comment288815>

    Put the final space at the beginning of the second line instead.



support/python3/post-build-result.py
Lines 50 (patched)
<https://reviews.apache.org/r/67504/#comment288814>

    Put the final space at the beginning of the second line instead.



support/python3/post-build-result.py
Lines 53 (patched)
<https://reviews.apache.org/r/67504/#comment288813>

    Put the final space at the beginning of the second line instead.



support/python3/post-build-result.py
Lines 61 (patched)
<https://reviews.apache.org/r/67504/#comment288816>

    s/`Method to retrieve`/`Retrieves`.



support/python3/post-build-result.py
Lines 67 (patched)
<https://reviews.apache.org/r/67504/#comment288810>

    Just use `if applied_reviews:`.



support/python3/post-build-result.py
Lines 69 (patched)
<https://reviews.apache.org/r/67504/#comment288811>

    Just use `if failed_command:`.



support/python3/post-build-result.py
Lines 71 (patched)
<https://reviews.apache.org/r/67504/#comment288812>

    Put the final space at the beginning of the second line instead.



support/python3/post-build-result.py
Lines 92 (patched)
<https://reviews.apache.org/r/67504/#comment288817>

    s/`Main method to post`/`Posts`.


- Armand Grillet


On June 14, 2018, 11:13 p.m., Dragos Schebesch wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67504/
> -----------------------------------------------------------
> 
> (Updated June 14, 2018, 11:13 p.m.)
> 
> 
> Review request for mesos, Andrew Schwartzmeyer and Armand Grillet.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added helper for posting the result of a build
> 
> 
> Diffs
> -----
> 
>   support/python3/post-build-result.py PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/67504/diff/2/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Dragos Schebesch
> 
>

Re: Review Request 67504: Added helper for posting the result of a build

Posted by Dragos Schebesch via Review Board <no...@reviews.apache.org>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67504/
-----------------------------------------------------------

(Updated June 14, 2018, 11:13 p.m.)


Review request for mesos, Andrew Schwartzmeyer and Armand Grillet.


Repository: mesos


Description
-------

Added helper for posting the result of a build


Diffs (updated)
-----

  support/python3/post-build-result.py PRE-CREATION 


Diff: https://reviews.apache.org/r/67504/diff/2/

Changes: https://reviews.apache.org/r/67504/diff/1-2/


Testing
-------


Thanks,

Dragos Schebesch