[GitHub] [tvm] vvchernov commented on a diff in pull request #13587: [Frontend] [ONNX] Support sequence_lens of GRU

[GitBox <gi...@apache.org>]

vvchernov commented on code in PR #13587:
URL: https://github.com/apache/tvm/pull/13587#discussion_r1046836569


##########
python/tvm/relay/frontend/common.py:
##########
@@ -737,6 +737,7 @@ def gru_cell(
     n_act=_op.tanh,
     backwards=False,
     linear_before_reset=True,

Review Comment:
   Please add description of arguments `linear_before_reset` and `sequence_lens`



##########
tests/python/frontend/onnx/test_forward.py:
##########
@@ -4211,6 +4218,22 @@ def verify_rnn_helper(target, dev, rnn_type):
         #     dev=dev,
         # )
 
+        # Testing with initial state
+        if rnn_type == "GRU":
+            verify_rnn(
+                seq_length=2,

Review Comment:
   Please increase seq_length (to 4-5 or more) and batch_size (to 4-8) for correct test of sequence with different lengths



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org