[GitHub] [spark] cloud-fan commented on a change in pull request #31621: [SPARK-34498][SQL][TESTS] fix the remaining problems in #31560

[GitBox <gi...@apache.org>]

cloud-fan commented on a change in pull request #31621:
URL: https://github.com/apache/spark/pull/31621#discussion_r584484677



##########
File path: sql/core/src/test/scala/org/apache/spark/sql/connector/SimpleWritableDataSource.scala
##########
@@ -41,11 +41,9 @@ import org.apache.spark.util.SerializableConfiguration
  * Each task writes data to `target/_temporary/uniqueId/$jobId-$partitionId-$attemptNumber`.
  * Each job moves files from `target/_temporary/uniqueId/` to `target`.
  */
-class SimpleWritableDataSource extends SimpleTableProvider with SessionConfigSupport {
+class SimpleWritableDataSource extends SimpleTableProvider {

Review comment:
       can we extend `TestingV2Source` instead?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org