You are viewing a plain text version of this content. The canonical link for it is here.

Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2021/09/08 02:08:11 UTC

[GitHub] [kafka] showuon commented on a change in pull request #11218: MINOR: optimize performAssignment to skip unnecessary check

showuon commented on a change in pull request #11218:
URL: https://github.com/apache/kafka/pull/11218#discussion_r703970666



##########
File path: clients/src/main/java/org/apache/kafka/clients/consumer/ConsumerConfig.java
##########
@@ -48,6 +53,16 @@
 public class ConsumerConfig extends AbstractConfig {
     private static final ConfigDef CONFIG;
 
+    // a list contains all the in-product assignor names. Should be updated when new assignor added.
+    // This is to help optimize the ConsumerCoordinator#performAssignment
+    public static final List<String> IN_PRODUCT_ASSIGNOR_NAMES =

Review comment:
       `ASSIGN_FROM_SUBSCRIBED_ASSIGNORS` sounds good to me. Updated. Let's wait for the jenkins build. Thank you! :)




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org