You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@jclouds.apache.org by Mahmoud Ismail <no...@github.com> on 2018/10/16 10:21:43 UTC
[jclouds/jclouds] Mark srouceImage as Nullable to avoid
NullPointerException while attaching local-ssd disk in GCE (#1242)
You can view, comment on, or merge this pull request online at:
https://github.com/jclouds/jclouds/pull/1242
-- Commit Summary --
* Mark srouceImage as Nullable
-- File Changes --
M providers/google-compute-engine/src/main/java/org/jclouds/googlecomputeengine/domain/AttachDisk.java (2)
-- Patch Links --
https://github.com/jclouds/jclouds/pull/1242.patch
https://github.com/jclouds/jclouds/pull/1242.diff
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1242
Re: [jclouds/jclouds] Mark srouceImage as Nullable to avoid
NullPointerException while attaching local-ssd disk in GCE (#1242)
Posted by Ignasi Barrera <no...@github.com>.
Closed #1242.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1242#event-1911717382
Re: [jclouds/jclouds] Mark srouceImage as Nullable to avoid
NullPointerException while attaching local-ssd disk in GCE (#1242)
Posted by Ignasi Barrera <no...@github.com>.
It's just a null check in a domain model that was not hit in a path reachable from the portable abstraction... I'm fine with the path as-is. @demobox?
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1242#issuecomment-430258452
Re: [jclouds/jclouds] Mark srouceImage as Nullable to avoid
NullPointerException while attaching local-ssd disk in GCE (#1242)
Posted by Andrew Phillips <no...@github.com>.
@nacx Should we consider adding any kinds of test(s) for this? Also, would a JIRA issue for tracking make sense here?
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1242#issuecomment-430212172
Re: [jclouds/jclouds] Mark srouceImage as Nullable to avoid
NullPointerException while attaching local-ssd disk in GCE (#1242)
Posted by Ignasi Barrera <no...@github.com>.
Merged to [master](http://git-wip-us.apache.org/repos/asf/jclouds/commit/f7b83f45) and [2.1.x](http://git-wip-us.apache.org/repos/asf/jclouds/commit/71dbce55). Thanks @maismail!
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1242#issuecomment-430940602
Re: [jclouds/jclouds] Mark srouceImage as Nullable to avoid
NullPointerException while attaching local-ssd disk in GCE (#1242)
Posted by Andrew Gaul <no...@github.com>.
@maismail Could you fix the srouceImage typo in the commit message?
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1242#issuecomment-430213378