You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@curator.apache.org by Randgalt <gi...@git.apache.org> on 2015/09/22 22:01:23 UTC
[GitHub] curator pull request: [CURATOR-264] Duplicate ephemeral nodes with...
GitHub user Randgalt opened a pull request:
https://github.com/apache/curator/pull/106
[CURATOR-264] Duplicate ephemeral nodes with same owner id
CURATOR-45 added findAndDeleteProtectedNodeInBackground to handle cas…es where a protected node can get lost. However, the code wasn't correctly handling namespaces
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/apache/curator CURATOR-264
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/curator/pull/106.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #106
----
commit f8f05be2e097c4c9be65e5110a376d461fd9cd9a
Author: randgalt <ra...@apache.org>
Date: 2015-09-22T19:59:41Z
CURATOR-45 added findAndDeleteProtectedNodeInBackground to handle cases where a protected node can get lost. However, the code wasn't correctly handling namespaces
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] curator pull request: [CURATOR-264] Duplicate ephemeral nodes with...
Posted by cammckenzie <gi...@git.apache.org>.
Github user cammckenzie commented on the pull request:
https://github.com/apache/curator/pull/106#issuecomment-142456418
So, the problem was that if a namespace was being used that it was being applied to the path twice? Once in the forPath() and again in findAndDeleteProtectedNodeInBackground()?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] curator pull request: [CURATOR-264] Duplicate ephemeral nodes with...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/curator/pull/106
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] curator pull request: [CURATOR-264] Duplicate ephemeral nodes with...
Posted by Randgalt <gi...@git.apache.org>.
Github user Randgalt commented on the pull request:
https://github.com/apache/curator/pull/106#issuecomment-142456662
It was being un-namespaced inside of the CreateBuilder. Then, that resolved path was passed via findAndDeleteProtectedNodeInBackground to the Curator routines which would resolve it again. So, that's twice, right? Yes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---