You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2022/11/29 15:56:18 UTC
[GitHub] [superset] codyml opened a new pull request, #22260: Fix dataMask typing and add null check.
codyml opened a new pull request, #22260:
URL: https://github.com/apache/superset/pull/22260
<!---
Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/
Example:
fix(dashboard): load charts correctly
-->
### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
This PR fixes a typing error that enabled an undefined key access error: `dataMask` isn't guaranteed to exist on type `FilterWithDataMask` because the source of that key, `DataMaskStateWithId`, isn't guaranteed to have a value for each filter ID.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
Example of error:
<img width="1792" alt="204566163-6539cf34-efa5-44d4-93bd-3fa1a90919a8" src="https://user-images.githubusercontent.com/13007381/204578285-a0038f65-c439-4eb0-9fab-798f092111db.png">
### TESTING INSTRUCTIONS
<!--- Required! What steps can be taken to manually verify the changes? -->
I had trouble reproducing this issue locally, but try various combinations of filled and unfilled filters and ensure that it doesn't happen again.
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [x] Required feature flags: `HORIZONTAL_FILTER_BAR`
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] zhaoyongjie commented on a diff in pull request #22260: fix(dashboard): Fix FilterWithDataMask typing and add null check
Posted by GitBox <gi...@apache.org>.
zhaoyongjie commented on code in PR #22260:
URL: https://github.com/apache/superset/pull/22260#discussion_r1035442923
##########
superset-frontend/src/dashboard/components/nativeFilters/FilterBar/FilterControls/FilterControls.tsx:
##########
@@ -128,7 +128,7 @@ const FilterControls: FC<FilterControlsProps> = ({
const activeOverflowedFiltersInScope = useMemo(
() =>
overflowedFiltersInScope.filter(
- filter => isNativeFilter(filter) && filter.dataMask.filterState?.value,
+ filter => isNativeFilter(filter) && filter.dataMask?.filterState?.value,
Review Comment:
Currently, there are `isNativeFilter` and `isFilterDivider` as the type guard, so I think we should introduce a new type guard for this use case, for example, `isFilterWithDataMask`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codyml commented on a diff in pull request #22260: fix(dashboard): Fix FilterWithDataMask typing and add null check
Posted by GitBox <gi...@apache.org>.
codyml commented on code in PR #22260:
URL: https://github.com/apache/superset/pull/22260#discussion_r1037659536
##########
superset-frontend/src/dashboard/components/nativeFilters/FilterBar/FilterControls/FilterControls.tsx:
##########
@@ -128,7 +128,7 @@ const FilterControls: FC<FilterControlsProps> = ({
const activeOverflowedFiltersInScope = useMemo(
() =>
overflowedFiltersInScope.filter(
- filter => isNativeFilter(filter) && filter.dataMask.filterState?.value,
+ filter => isNativeFilter(filter) && filter.dataMask?.filterState?.value,
Review Comment:
Fixed in https://github.com/apache/superset/pull/22307!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codyml commented on pull request #22260: fix(dashboard): Fix FilterWithDataMask typing and add null check
Posted by GitBox <gi...@apache.org>.
codyml commented on PR #22260:
URL: https://github.com/apache/superset/pull/22260#issuecomment-1330957093
Thanks for the reviews, @villebro or @kgabryje feel free to merge!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] villebro merged pull request #22260: fix(dashboard): Fix FilterWithDataMask typing and add null check
Posted by GitBox <gi...@apache.org>.
villebro merged PR #22260:
URL: https://github.com/apache/superset/pull/22260
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org