You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/04/25 01:53:50 UTC

[GitHub] [pulsar] congbobo184 commented on a diff in pull request #15296: [Improve][txn] Add admin api updateTransactionCoordinatorNumber

congbobo184 commented on code in PR #15296:
URL: https://github.com/apache/pulsar/pull/15296#discussion_r857211716


##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/v3/Transactions.java:
##########
@@ -314,4 +315,17 @@ public void getPendingAckInternalStats(@Suspended final AsyncResponse asyncRespo
             resumeAsyncResponseExceptionally(asyncResponse, ex);
         }
     }
+
+    @POST
+    @Path("/transactionCoordinator/partitions")
+    @ApiResponses(value = {
+            @ApiResponse(code = 503, message = "This Broker is not configured "
+                    + "with transactionCoordinatorEnabled=true."),
+            @ApiResponse(code = 406, message = "The number of partitions should be more than "
+                    + "the current number of transaction coordinator partitions"
+                    + " and less than or equal to maxNumPartitionsPerPartitionedTopic")})
+    public void updateTransactionCoordinatorNumber(int numPartitions) {
+        checkTransactionCoordinatorEnabled();

Review Comment:
   should add auth



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org