You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Gergely Fürnstáhl (Code Review)" <ge...@cloudera.org> on 2022/06/24 13:31:32 UTC
[Impala-ASF-CR] IMPALA-11391: Fixed race condition in test drop managed kudu table
Gergely Fürnstáhl has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18667
Change subject: IMPALA-11391: Fixed race condition in test_drop_managed_kudu_table
......................................................................
IMPALA-11391: Fixed race condition in test_drop_managed_kudu_table
test_drop_managed_kudu_table uses exception to verify the deleted table
is really missing. Depending on timing, this exception could have been
raised in several control pathes with different content. Now the test
waits for event processing, meaning Analyzer will consistently catch
the missing table and raise the same exception.
Change-Id: I857098c87fcd44d945dd33108bcfdfaa2ca939df
---
M tests/custom_cluster/test_kudu.py
1 file changed, 7 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/67/18667/2
--
To view, visit http://gerrit.cloudera.org:8080/18667
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I857098c87fcd44d945dd33108bcfdfaa2ca939df
Gerrit-Change-Number: 18667
Gerrit-PatchSet: 2
Gerrit-Owner: Gergely Fürnstáhl <gf...@cloudera.com>
[Impala-ASF-CR] IMPALA-11391: Fixed race condition in test drop managed kudu table
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/18667 )
Change subject: IMPALA-11391: Fixed race condition in test_drop_managed_kudu_table
......................................................................
IMPALA-11391: Fixed race condition in test_drop_managed_kudu_table
test_drop_managed_kudu_table uses exception to verify the deleted table
is really missing. Depending on timing, this exception could have been
raised in several control pathes with different content. Now the test
waits for event processing, meaning Analyzer will consistently catch
the missing table and raise the same exception.
Change-Id: I857098c87fcd44d945dd33108bcfdfaa2ca939df
Reviewed-on: http://gerrit.cloudera.org:8080/18667
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M tests/custom_cluster/test_kudu.py
1 file changed, 7 insertions(+), 2 deletions(-)
Approvals:
Impala Public Jenkins: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/18667
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I857098c87fcd44d945dd33108bcfdfaa2ca939df
Gerrit-Change-Number: 18667
Gerrit-PatchSet: 4
Gerrit-Owner: Gergely Fürnstáhl <gf...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@apache.org>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
[Impala-ASF-CR] IMPALA-11391: Fixed race condition in test drop managed kudu table
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18667 )
Change subject: IMPALA-11391: Fixed race condition in test_drop_managed_kudu_table
......................................................................
Patch Set 3: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/18667
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I857098c87fcd44d945dd33108bcfdfaa2ca939df
Gerrit-Change-Number: 18667
Gerrit-PatchSet: 3
Gerrit-Owner: Gergely Fürnstáhl <gf...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@apache.org>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Wed, 29 Jun 2022 14:31:48 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11391: Fixed race condition in test drop managed kudu table
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18667 )
Change subject: IMPALA-11391: Fixed race condition in test_drop_managed_kudu_table
......................................................................
Patch Set 3:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/8277/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/18667
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I857098c87fcd44d945dd33108bcfdfaa2ca939df
Gerrit-Change-Number: 18667
Gerrit-PatchSet: 3
Gerrit-Owner: Gergely Fürnstáhl <gf...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@apache.org>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Wed, 29 Jun 2022 09:48:20 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11391: Fixed race condition in test drop managed kudu table
Posted by "Zoltan Borok-Nagy (Code Review)" <ge...@cloudera.org>.
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/18667 )
Change subject: IMPALA-11391: Fixed race condition in test_drop_managed_kudu_table
......................................................................
Patch Set 2: Code-Review+2
Thanks for fixing this! LGTM!
--
To view, visit http://gerrit.cloudera.org:8080/18667
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I857098c87fcd44d945dd33108bcfdfaa2ca939df
Gerrit-Change-Number: 18667
Gerrit-PatchSet: 2
Gerrit-Owner: Gergely Fürnstáhl <gf...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@apache.org>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Wed, 29 Jun 2022 09:26:51 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11391: Fixed race condition in test drop managed kudu table
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18667 )
Change subject: IMPALA-11391: Fixed race condition in test_drop_managed_kudu_table
......................................................................
Patch Set 2:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/10867/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/18667
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I857098c87fcd44d945dd33108bcfdfaa2ca939df
Gerrit-Change-Number: 18667
Gerrit-PatchSet: 2
Gerrit-Owner: Gergely Fürnstáhl <gf...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Fri, 24 Jun 2022 13:53:08 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11391: Fixed race condition in test drop managed kudu table
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18667 )
Change subject: IMPALA-11391: Fixed race condition in test_drop_managed_kudu_table
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/18667
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I857098c87fcd44d945dd33108bcfdfaa2ca939df
Gerrit-Change-Number: 18667
Gerrit-PatchSet: 3
Gerrit-Owner: Gergely Fürnstáhl <gf...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@apache.org>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Wed, 29 Jun 2022 09:48:19 +0000
Gerrit-HasComments: No