You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@mesos.apache.org by Jie Yu <yu...@gmail.com> on 2013/11/26 02:07:25 UTC

Review Request 15850: Rewrote zookeeper watcher initialization using process::Once.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15850/
-----------------------------------------------------------

Review request for mesos, Benjamin Hindman, Ben Mahler, and Vinod Kone.


Repository: mesos-git


Description
-------

See summary.

Not sure if this is related to
https://issues.apache.org/jira/browse/MESOS-817

But the original code has a memory consistency issue.


Diffs
-----

  src/zookeeper/zookeeper.cpp ca4a61d 

Diff: https://reviews.apache.org/r/15850/diff/


Testing
-------

make check


Thanks,

Jie Yu

Re: Review Request 15850: Rewrote zookeeper watcher initialization using process::Once.

Posted by Benjamin Hindman <be...@berkeley.edu>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15850/#review29410
-----------------------------------------------------------

Ship it!


Ship It!

- Benjamin Hindman


On Nov. 26, 2013, 1:07 a.m., Jie Yu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15850/
> -----------------------------------------------------------
> 
> (Updated Nov. 26, 2013, 1:07 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Ben Mahler, and Vinod Kone.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> See summary.
> 
> Not sure if this is related to
> https://issues.apache.org/jira/browse/MESOS-817
> 
> But the original code has a memory consistency issue.
> 
> 
> Diffs
> -----
> 
>   src/zookeeper/zookeeper.cpp ca4a61d 
> 
> Diff: https://reviews.apache.org/r/15850/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>