You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@hive.apache.org by GitBox <gi...@apache.org> on 2022/02/03 17:27:07 UTC

[GitHub] [hive] zabetak opened a new pull request #2996: HIVE-25919: ClassCastException when pushing boolean column predicate in HBaseStorageHandler

zabetak opened a new pull request #2996:
URL: https://github.com/apache/hive/pull/2996


   ### What changes were proposed in this pull request?
   
   The predicate analyzer can only handle expressions of the form:
   1. `col comp_op constant`
   2. `constant comp_op col`
   and these are always `ExprNodeGenericFuncDesc`.
   
   The new if clause ensures that we are never going to handle anything that is not supported.
   
   ### Why are the changes needed?
   Avoids the `ClassCastException` during predicate pushdown.
   
   ### Does this PR introduce _any_ user-facing change?
   No apart from solving the problem.
   
   ### How was this patch tested?
   `mvn test -Dtest=TestHBaseCliDriver -Dqfile="hbase_ppd_boolean_cols.q"`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org

[GitHub] [hive] zabetak closed pull request #2996: HIVE-25919: ClassCastException when pushing boolean column predicate in HBaseStorageHandler

Posted by GitBox <gi...@apache.org>.
zabetak closed pull request #2996:
URL: https://github.com/apache/hive/pull/2996


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org

[GitHub] [hive] abstractdog commented on a change in pull request #2996: HIVE-25919: ClassCastException when pushing boolean column predicate in HBaseStorageHandler

Posted by GitBox <gi...@apache.org>.
abstractdog commented on a change in pull request #2996:
URL: https://github.com/apache/hive/pull/2996#discussion_r800076144



##########
File path: hbase-handler/src/test/queries/positive/hbase_ppd_boolean_cols.q
##########
@@ -0,0 +1,8 @@
+CREATE TABLE hbase_table(row_key string, c1 boolean, c2 boolean)
+STORED BY 'org.apache.hadoop.hive.hbase.HBaseStorageHandler'
+WITH SERDEPROPERTIES (
+"hbase.columns.mapping" = ":key,cf:c1,cf:c2"
+);
+

Review comment:
       even if this is about a compile-time issue, can include a real query too, not just an explain?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org

[GitHub] [hive] abstractdog commented on pull request #2996: HIVE-25919: ClassCastException when pushing boolean column predicate in HBaseStorageHandler

Posted by GitBox <gi...@apache.org>.
abstractdog commented on pull request #2996:
URL: https://github.com/apache/hive/pull/2996#issuecomment-1033510670


   +1, very neat, @zabetak 
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org

[GitHub] [hive] zabetak commented on a change in pull request #2996: HIVE-25919: ClassCastException when pushing boolean column predicate in HBaseStorageHandler

Posted by GitBox <gi...@apache.org>.
zabetak commented on a change in pull request #2996:
URL: https://github.com/apache/hive/pull/2996#discussion_r801655431



##########
File path: hbase-handler/src/test/queries/positive/hbase_ppd_boolean_cols.q
##########
@@ -0,0 +1,8 @@
+CREATE TABLE hbase_table(row_key string, c1 boolean, c2 boolean)
+STORED BY 'org.apache.hadoop.hive.hbase.HBaseStorageHandler'
+WITH SERDEPROPERTIES (
+"hbase.columns.mapping" = ":key,cf:c1,cf:c2"
+);
+

Review comment:
       Fixed in https://github.com/apache/hive/pull/2996/commits/42333553fbac3949e4f0c65e21b6237ca171b971. Please have another look when you find some time.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org