You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@kvrocks.apache.org by GitBox <gi...@apache.org> on 2022/11/25 08:25:22 UTC
[GitHub] [incubator-kvrocks] PragmaTwice opened a new pull request, #1140: Introduce command register mechanism to allow splitting command definition to multiple TUs
PragmaTwice opened a new pull request, #1140:
URL: https://github.com/apache/incubator-kvrocks/pull/1140
To make #1138 possible, we must have a register mechanism instead of a global command table, which is provided in this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks] PragmaTwice commented on a diff in pull request #1140: Introduce command register mechanism to allow splitting command definition to multiple TUs
Posted by GitBox <gi...@apache.org>.
PragmaTwice commented on code in PR #1140:
URL: https://github.com/apache/incubator-kvrocks/pull/1140#discussion_r1032772494
##########
src/commands/redis_cmd.cc:
##########
@@ -6312,8 +6288,7 @@ const CommandAttributes redisCommandTable[]{
MakeCmdAttr<CommandDisk>("disk", 3, "read-only", 0, 0, 0),
MakeCmdAttr<CommandHello>("hello", -1, "read-only ok-loading", 0, 0, 0),
- MakeCmdAttr<CommandTTL>("ttl", 2, "read-only", 1, 1, 1),
- MakeCmdAttr<CommandPTTL>("pttl", 2, "read-only", 1, 1, 1),
+ MakeCmdAttr<CommandTTL>("ttl", 2, "read-only", 1, 1, 1), MakeCmdAttr<CommandPTTL>("pttl", 2, "read-only", 1, 1, 1),
Review Comment:
Yah, I do not edit them manually.
##########
src/commands/redis_cmd.cc:
##########
@@ -6312,8 +6288,7 @@ const CommandAttributes redisCommandTable[]{
MakeCmdAttr<CommandDisk>("disk", 3, "read-only", 0, 0, 0),
MakeCmdAttr<CommandHello>("hello", -1, "read-only ok-loading", 0, 0, 0),
- MakeCmdAttr<CommandTTL>("ttl", 2, "read-only", 1, 1, 1),
- MakeCmdAttr<CommandPTTL>("pttl", 2, "read-only", 1, 1, 1),
+ MakeCmdAttr<CommandTTL>("ttl", 2, "read-only", 1, 1, 1), MakeCmdAttr<CommandPTTL>("pttl", 2, "read-only", 1, 1, 1),
Review Comment:
Yah, I did not edit them manually.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks] PragmaTwice commented on pull request #1140: Introduce command register mechanism to allow splitting command definition to multiple TUs
Posted by GitBox <gi...@apache.org>.
PragmaTwice commented on PR #1140:
URL: https://github.com/apache/incubator-kvrocks/pull/1140#issuecomment-1328060597
Thanks all. Merging...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks] PragmaTwice merged pull request #1140: Introduce command register mechanism to allow splitting command definition to multiple TUs
Posted by GitBox <gi...@apache.org>.
PragmaTwice merged PR #1140:
URL: https://github.com/apache/incubator-kvrocks/pull/1140
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks] git-hulk commented on a diff in pull request #1140: Introduce command register mechanism to allow splitting command definition to multiple TUs
Posted by GitBox <gi...@apache.org>.
git-hulk commented on code in PR #1140:
URL: https://github.com/apache/incubator-kvrocks/pull/1140#discussion_r1032768843
##########
src/commands/redis_cmd.cc:
##########
@@ -6312,8 +6288,7 @@ const CommandAttributes redisCommandTable[]{
MakeCmdAttr<CommandDisk>("disk", 3, "read-only", 0, 0, 0),
MakeCmdAttr<CommandHello>("hello", -1, "read-only ok-loading", 0, 0, 0),
- MakeCmdAttr<CommandTTL>("ttl", 2, "read-only", 1, 1, 1),
- MakeCmdAttr<CommandPTTL>("pttl", 2, "read-only", 1, 1, 1),
+ MakeCmdAttr<CommandTTL>("ttl", 2, "read-only", 1, 1, 1), MakeCmdAttr<CommandPTTL>("pttl", 2, "read-only", 1, 1, 1),
Review Comment:
Does it auto-format by clang-format?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org