[GitHub] [guacamole-client] madmath03 edited a comment on issue #470: GUACAMOLE-124: Add full-screen action

[GitBox <gi...@apache.org>]

madmath03 edited a comment on issue #470: GUACAMOLE-124: Add full-screen action
URL: https://github.com/apache/guacamole-client/pull/470#issuecomment-582584855
 
 
   > Overall this looks pretty solid to me. My only question is how much testing you've done with scaling/resizing with this? Presumably when it goes to full-screen the screen resolution changes, which, depending on the protocol in use for the connection, will result in either an on-the-fly resize (RDP, maybe SSH/Telnet), a disconnect/reconnect (RDP), or some extra black space around the screen area. What sort of behavior have you seen?
   
   I did some more tests on different devices / browsers and connections. Here are the results:
   
   | Device / Browser | :checkered_flag: Windows RDP | :penguin: Linux SSH | :penguin: Linux VNC (TigerVNC) |
   | ------------------- | --------------- | ----------- | ------------------------ |
   | :checkered_flag: Windows / Chromium | :warning: | :white_check_mark: | :white_check_mark: |
   | :checkered_flag: Windows / Firefox | :warning: | :white_check_mark: | :white_check_mark: |
   | :checkered_flag: Windows / Edge | :warning: | :white_check_mark: | :white_check_mark: |
   | :checkered_flag: Windows / IE 11 | :no_entry_sign: | :no_entry_sign: | :no_entry_sign: |
   | :robot: Android Tablet / Chromium | :warning: | :white_check_mark: | :white_check_mark: |
   | :robot: Android Tablet / Firefox | :warning: | :white_check_mark: | :white_check_mark: |
   | :green_apple: iPhone / Safari | :x: | :x: | :x: |
   
   -    :white_check_mark: : Fullscreen works properly and connection is immediately resized
   -    :warning: : Fullscreen button works but Windows RDP connection displays empty space and needs to be restarted to be resized (disconnect / reconnect, no need to go back to home)
   -    :no_entry_sign: : Fullscreen button works but only displays a black screen in connection, whatever the connection type
   -    :x: : Fullscreen button does not trigger fullscreen
   
   So basically:
   * IE 11 and Safari do not work
   * RDP connection needs reconnect (seems to be the normal behavior of RDP)
   * everything else is good
   
   @necouchman & @mike-jumper : I do not have a Mac to debug behavior on Safari, and I do not believe IE 11 is relevant anymore, so I think that's good enough to be used, or at least to be reviewed.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services