You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/02/24 02:36:40 UTC
[GitHub] [airflow] rustikk opened a new pull request #21780: Default args type check
rustikk opened a new pull request #21780:
URL: https://github.com/apache/airflow/pull/21780
closes: #21768
When the default_args is anything but a dictionary or None a nasty error shows. This commit adds a TypeError if anything other than a dictionary or None is passed to it and returns "default_args must be a dictionary".
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] dstandish removed a comment on pull request #21780: default_args type check
Posted by GitBox <gi...@apache.org>.
dstandish removed a comment on pull request #21780:
URL: https://github.com/apache/airflow/pull/21780#issuecomment-1050463296
> I did the rebase wrong so I'm closing this and making a new PR.
@rustikk you can force push it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] rustikk closed pull request #21780: default_args type check
Posted by GitBox <gi...@apache.org>.
rustikk closed pull request #21780:
URL: https://github.com/apache/airflow/pull/21780
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] rustikk commented on pull request #21780: default_args type check
Posted by GitBox <gi...@apache.org>.
rustikk commented on pull request #21780:
URL: https://github.com/apache/airflow/pull/21780#issuecomment-1050300466
Since you can use default_args in operators and in TaskGroup's do you want the type check to go in the code for the baseoperator and task group utility?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] rustikk commented on pull request #21780: default_args type check
Posted by GitBox <gi...@apache.org>.
rustikk commented on pull request #21780:
URL: https://github.com/apache/airflow/pull/21780#issuecomment-1050432420
I did the rebase wrong so I'm closing this and making a new PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] dstandish commented on pull request #21780: default_args type check
Posted by GitBox <gi...@apache.org>.
dstandish commented on pull request #21780:
URL: https://github.com/apache/airflow/pull/21780#issuecomment-1050463296
> I did the rebase wrong so I'm closing this and making a new PR.
@rustikk you can force push it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] rustikk removed a comment on pull request #21780: default_args type check
Posted by GitBox <gi...@apache.org>.
rustikk removed a comment on pull request #21780:
URL: https://github.com/apache/airflow/pull/21780#issuecomment-1050300466
Since you can use default_args in operators and in TaskGroup's do you want the type check to go in the code for the baseoperator and task group utility?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org