You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by "kennknowles (via GitHub)" <gi...@apache.org> on 2023/04/26 19:26:41 UTC
[GitHub] [beam] kennknowles opened a new pull request, #26441: Eliminate nullness errors from sdks/java/extensions/ml
kennknowles opened a new pull request, #26441:
URL: https://github.com/apache/beam/pull/26441
Fixes #20499
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [x] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
- [x] Update `CHANGES.md` with noteworthy changes.
- [x] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/get-started-contributing/#make-the-reviewers-job-easier).
To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #26441: Eliminate nullness errors from sdks/java/extensions/ml
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #26441:
URL: https://github.com/apache/beam/pull/26441#issuecomment-1526023690
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kennknowles commented on pull request #26441: Eliminate nullness errors from sdks/java/extensions/ml
Posted by "kennknowles (via GitHub)" <gi...@apache.org>.
kennknowles commented on PR #26441:
URL: https://github.com/apache/beam/pull/26441#issuecomment-1538705380
Run Java PreCommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kennknowles commented on pull request #26441: Eliminate nullness errors from sdks/java/extensions/ml
Posted by "kennknowles (via GitHub)" <gi...@apache.org>.
kennknowles commented on PR #26441:
URL: https://github.com/apache/beam/pull/26441#issuecomment-1538968679
More FlinkRequiresStableInputTest
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kennknowles commented on pull request #26441: Eliminate nullness errors from sdks/java/extensions/ml
Posted by "kennknowles (via GitHub)" <gi...@apache.org>.
kennknowles commented on PR #26441:
URL: https://github.com/apache/beam/pull/26441#issuecomment-1541201531
Revert at #26620 both because it was not reviewed and because of post commit failure.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kennknowles commented on pull request #26441: Eliminate nullness errors from sdks/java/extensions/ml
Posted by "kennknowles (via GitHub)" <gi...@apache.org>.
kennknowles commented on PR #26441:
URL: https://github.com/apache/beam/pull/26441#issuecomment-1529949136
Probably the "java precommit" should not even run for this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kennknowles commented on pull request #26441: Eliminate nullness errors from sdks/java/extensions/ml
Posted by "kennknowles (via GitHub)" <gi...@apache.org>.
kennknowles commented on PR #26441:
URL: https://github.com/apache/beam/pull/26441#issuecomment-1529993154
run java precommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kennknowles commented on pull request #26441: Eliminate nullness errors from sdks/java/extensions/ml
Posted by "kennknowles (via GitHub)" <gi...@apache.org>.
kennknowles commented on PR #26441:
URL: https://github.com/apache/beam/pull/26441#issuecomment-1538968845
Run Java PreCommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kennknowles commented on pull request #26441: Eliminate nullness errors from sdks/java/extensions/ml
Posted by "kennknowles (via GitHub)" <gi...@apache.org>.
kennknowles commented on PR #26441:
URL: https://github.com/apache/beam/pull/26441#issuecomment-1523986602
run java precommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kennknowles commented on pull request #26441: Eliminate nullness errors from sdks/java/extensions/ml
Posted by "kennknowles (via GitHub)" <gi...@apache.org>.
kennknowles commented on PR #26441:
URL: https://github.com/apache/beam/pull/26441#issuecomment-1528543070
Run Java PreCommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kennknowles commented on pull request #26441: Eliminate nullness errors from sdks/java/extensions/ml
Posted by "kennknowles (via GitHub)" <gi...@apache.org>.
kennknowles commented on PR #26441:
URL: https://github.com/apache/beam/pull/26441#issuecomment-1526022219
R: @damondouglas
(for the bots sake)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kennknowles merged pull request #26441: Eliminate nullness errors from sdks/java/extensions/ml
Posted by "kennknowles (via GitHub)" <gi...@apache.org>.
kennknowles merged PR #26441:
URL: https://github.com/apache/beam/pull/26441
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kennknowles commented on pull request #26441: Eliminate nullness errors from sdks/java/extensions/ml
Posted by "kennknowles (via GitHub)" <gi...@apache.org>.
kennknowles commented on PR #26441:
URL: https://github.com/apache/beam/pull/26441#issuecomment-1529948859
run java precommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kennknowles commented on a diff in pull request #26441: Eliminate nullness errors from sdks/java/extensions/ml
Posted by "kennknowles (via GitHub)" <gi...@apache.org>.
kennknowles commented on code in PR #26441:
URL: https://github.com/apache/beam/pull/26441#discussion_r1189290168
##########
sdks/java/extensions/ml/src/main/java/org/apache/beam/sdk/extensions/ml/RecommendationAIWriteUserEvent.java:
##########
@@ -60,13 +58,13 @@ static Builder newBuilder() {
}
/** @return ID of Google Cloud project to be used for creating user events. */
- public abstract @Nullable String projectId();
Review Comment:
Oh sheesh. You are right. My mistake! I thought this was reviewed. I was kicking it for a long time on flakes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #26441: Eliminate nullness errors from sdks/java/extensions/ml
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #26441:
URL: https://github.com/apache/beam/pull/26441#issuecomment-1524012329
Assigning reviewers. If you would like to opt out of this review, comment `assign to next reviewer`:
R: @Abacn for label java.
Available commands:
- `stop reviewer notifications` - opt out of the automated review tooling
- `remind me after tests pass` - tag the comment author after tests pass
- `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)
The PR bot will only process comments in the main thread (not review comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] Abacn commented on a diff in pull request #26441: Eliminate nullness errors from sdks/java/extensions/ml
Posted by "Abacn (via GitHub)" <gi...@apache.org>.
Abacn commented on code in PR #26441:
URL: https://github.com/apache/beam/pull/26441#discussion_r1189224556
##########
sdks/java/extensions/ml/src/main/java/org/apache/beam/sdk/extensions/ml/RecommendationAIWriteUserEvent.java:
##########
@@ -60,13 +58,13 @@ static Builder newBuilder() {
}
/** @return ID of Google Cloud project to be used for creating user events. */
- public abstract @Nullable String projectId();
Review Comment:
Due to the change here.
In general it is possible breakage could happen elsewhere forcing previously nullable parameters to nonnull
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] Abacn commented on a diff in pull request #26441: Eliminate nullness errors from sdks/java/extensions/ml
Posted by "Abacn (via GitHub)" <gi...@apache.org>.
Abacn commented on code in PR #26441:
URL: https://github.com/apache/beam/pull/26441#discussion_r1189224942
##########
sdks/java/extensions/ml/src/main/java/org/apache/beam/sdk/extensions/ml/RecommendationAIWriteUserEvent.java:
##########
@@ -60,13 +58,13 @@ static Builder newBuilder() {
}
/** @return ID of Google Cloud project to be used for creating user events. */
- public abstract @Nullable String projectId();
Review Comment:
btw was this PR unreviewed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] Abacn commented on pull request #26441: Eliminate nullness errors from sdks/java/extensions/ml
Posted by "Abacn (via GitHub)" <gi...@apache.org>.
Abacn commented on PR #26441:
URL: https://github.com/apache/beam/pull/26441#issuecomment-1541022799
Possible related postcommit test failure: https://ci-beam.apache.org/job/beam_PostCommit_Java/10394/testReport/junit/org.apache.beam.sdk.extensions.ml/RecommendationAIUserEventIT/createUserEvent/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kennknowles commented on pull request #26441: Eliminate nullness errors from sdks/java/extensions/ml
Posted by "kennknowles (via GitHub)" <gi...@apache.org>.
kennknowles commented on PR #26441:
URL: https://github.com/apache/beam/pull/26441#issuecomment-1526022000
Run Java PreCommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org