You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/04/25 15:01:09 UTC
[GitHub] [incubator-nuttx-apps] xiaoxiang781216 opened a new pull request #202: Make more the default stack size to DEFAULT_TASK_STACKSIZE
xiaoxiang781216 opened a new pull request #202:
URL: https://github.com/apache/incubator-nuttx-apps/pull/202
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] patacongo commented on a change in pull request #202: Make more the default stack size to DEFAULT_TASK_STACKSIZE
Posted by GitBox <gi...@apache.org>.
patacongo commented on a change in pull request #202:
URL: https://github.com/apache/incubator-nuttx-apps/pull/202#discussion_r415098950
##########
File path: system/hex2bin/Kconfig
##########
@@ -24,7 +24,7 @@ if SYSTEM_HEX2BIN_BUILTIN
config SYSTEM_HEX2BIN_STACKSIZE
int "hex2bin stack size"
- default 1536
Review comment:
This changes the default stack size
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] patacongo commented on a change in pull request #202: Make more the default stack size to DEFAULT_TASK_STACKSIZE
Posted by GitBox <gi...@apache.org>.
patacongo commented on a change in pull request #202:
URL: https://github.com/apache/incubator-nuttx-apps/pull/202#discussion_r415099054
##########
File path: system/nxplayer/Kconfig
##########
@@ -21,7 +21,7 @@ config NXPLAYER_MAINTHREAD_STACKSIZE
config NXPLAYER_PLAYTHREAD_STACKSIZE
int "NxPlayer thread stack size"
- default 1500
Review comment:
This changes the default stack size
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on pull request #202: Make more the default stack size to DEFAULT_TASK_STACKSIZE
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on pull request #202:
URL: https://github.com/apache/incubator-nuttx-apps/pull/202#issuecomment-619402848
Need merge https://github.com/apache/incubator-nuttx/pull/872 fist to pass the check.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on a change in pull request #202: Make more the default stack size to DEFAULT_TASK_STACKSIZE
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #202:
URL: https://github.com/apache/incubator-nuttx-apps/pull/202#discussion_r415088331
##########
File path: examples/mount/Kconfig
##########
@@ -35,7 +35,7 @@ if !EXAMPLES_MOUNT_BLOCKDEVICE
config EXAMPLES_MOUNT_NSECTORS
int "RAM disk number of sectors"
- default DEFAULT_TASK_STACKSIZE
+ default 2048
Review comment:
This is a wrong change by:
commit e7156be066c7427e2afb56521c3eaf56d7623e25
Author: YAMAMOTO Takashi <ya...@midokura.com>
Date: Fri Mar 27 14:10:33 2020 +0900
Change the defaults of stack size configs to DEFAULT_TASK_STACKSIZE
This commit changes only ones with the default 2048 and
leaves the others.
E.g. this leaves SYSTEM_RAMTEST_STACKSIZE, whose default is 1024.
I guess those need to be inspected one-by-one.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] patacongo commented on pull request #202: Make more the default stack size to DEFAULT_TASK_STACKSIZE
Posted by GitBox <gi...@apache.org>.
patacongo commented on pull request #202:
URL: https://github.com/apache/incubator-nuttx-apps/pull/202#issuecomment-619412645
Although this change is improper and must not be merged, there are also two important bugfixes in the change. I pulled those out and submitted them separately as PR204.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] Ouss4 commented on pull request #202: Make more the default stack size to DEFAULT_TASK_STACKSIZE
Posted by GitBox <gi...@apache.org>.
Ouss4 commented on pull request #202:
URL: https://github.com/apache/incubator-nuttx-apps/pull/202#issuecomment-619404570
There seems to be an issue with the checks (or Github), I restarted both this PR and nuttx#872 a couple of times, they always fail somewhere.
Maybe we need @liuguo09 or @btashton inputs' for that.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] patacongo commented on a change in pull request #202: Make more the default stack size to DEFAULT_TASK_STACKSIZE
Posted by GitBox <gi...@apache.org>.
patacongo commented on a change in pull request #202:
URL: https://github.com/apache/incubator-nuttx-apps/pull/202#discussion_r415098983
##########
File path: system/hex2bin/Kconfig
##########
@@ -75,7 +75,7 @@ if SYSTEM_HEX2MEM_BUILTIN
config SYSTEM_HEX2MEM_STACKSIZE
int "hex2mem stack size"
- default 1536
Review comment:
This changes the default stack size
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] patacongo commented on pull request #202: Make more the default stack size to DEFAULT_TASK_STACKSIZE
Posted by GitBox <gi...@apache.org>.
patacongo commented on pull request #202:
URL: https://github.com/apache/incubator-nuttx-apps/pull/202#issuecomment-619409936
After reviewing an trying to comment on all of the problems and risks. I come to the conclusion that this change is wrong and must not be merged.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] patacongo commented on a change in pull request #202: Make more the default stack size to DEFAULT_TASK_STACKSIZE
Posted by GitBox <gi...@apache.org>.
patacongo commented on a change in pull request #202:
URL: https://github.com/apache/incubator-nuttx-apps/pull/202#discussion_r415099020
##########
File path: system/lm75/Kconfig
##########
@@ -32,7 +32,7 @@ endchoice
config SYSTEM_LM75_STACKSIZE
int "Stack size (bytes)"
- default 1024
Review comment:
This changes the default stack size
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] patacongo commented on a change in pull request #202: Make more the default stack size to DEFAULT_TASK_STACKSIZE
Posted by GitBox <gi...@apache.org>.
patacongo commented on a change in pull request #202:
URL: https://github.com/apache/incubator-nuttx-apps/pull/202#discussion_r415099202
##########
File path: system/usbmsc/Kconfig
##########
@@ -156,7 +156,7 @@ endif # SYSTEM_USBMSC_TRACE
config SYSTEM_USBMSC_CMD_STACKSIZE
int "Stacksize of msconn and msdis commands"
- default 768
Review comment:
This is a horrendous increate in the default stack size
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] Ouss4 commented on a change in pull request #202: Make more the default stack size to DEFAULT_TASK_STACKSIZE
Posted by GitBox <gi...@apache.org>.
Ouss4 commented on a change in pull request #202:
URL: https://github.com/apache/incubator-nuttx-apps/pull/202#discussion_r415082959
##########
File path: examples/mount/Kconfig
##########
@@ -35,7 +35,7 @@ if !EXAMPLES_MOUNT_BLOCKDEVICE
config EXAMPLES_MOUNT_NSECTORS
int "RAM disk number of sectors"
- default DEFAULT_TASK_STACKSIZE
+ default 2048
Review comment:
Isn't that supposed to be the opposite way?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] patacongo commented on a change in pull request #202: Make more the default stack size to DEFAULT_TASK_STACKSIZE
Posted by GitBox <gi...@apache.org>.
patacongo commented on a change in pull request #202:
URL: https://github.com/apache/incubator-nuttx-apps/pull/202#discussion_r415099103
##########
File path: system/nxrecorder/Kconfig
##########
@@ -15,7 +15,7 @@ if SYSTEM_NXRECORDER
config NXRECORDER_RECORDTHREAD_STACKSIZE
int "NxRecorder thread stack size"
- default 1500
Review comment:
This changes the default stack size
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] patacongo commented on a change in pull request #202: Make more the default stack size to DEFAULT_TASK_STACKSIZE
Posted by GitBox <gi...@apache.org>.
patacongo commented on a change in pull request #202:
URL: https://github.com/apache/incubator-nuttx-apps/pull/202#discussion_r415099162
##########
File path: system/tee/Kconfig
##########
@@ -13,7 +13,7 @@ if SYSTEM_TEE
config SYSTEM_TEE_STACKSIZE
int "tee stack size"
- default 1536
Review comment:
This changes the default stack size
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] Ouss4 commented on a change in pull request #202: Make more the default stack size to DEFAULT_TASK_STACKSIZE
Posted by GitBox <gi...@apache.org>.
Ouss4 commented on a change in pull request #202:
URL: https://github.com/apache/incubator-nuttx-apps/pull/202#discussion_r415085804
##########
File path: examples/mount/Kconfig
##########
@@ -35,7 +35,7 @@ if !EXAMPLES_MOUNT_BLOCKDEVICE
config EXAMPLES_MOUNT_NSECTORS
int "RAM disk number of sectors"
- default DEFAULT_TASK_STACKSIZE
+ default 2048
Review comment:
Never mind, I see it has nothing to do with a task.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] patacongo commented on a change in pull request #202: Make more the default stack size to DEFAULT_TASK_STACKSIZE
Posted by GitBox <gi...@apache.org>.
patacongo commented on a change in pull request #202:
URL: https://github.com/apache/incubator-nuttx-apps/pull/202#discussion_r415098866
##########
File path: graphics/nxwm/Kconfig
##########
@@ -504,7 +504,7 @@ config NXWM_TOUCHSCREEN_LISTENERPRIO
config NXWM_TOUCHSCREEN_LISTENERSTACK
int "Touchscreen Listener Task Stack Size"
- default 1024
Review comment:
This changes the default stack size
##########
File path: netutils/discover/Kconfig
##########
@@ -15,7 +15,7 @@ if NETUTILS_DISCOVER
config DISCOVER_STACK_SIZE
int "Discover Daemon Stack Size"
- default 1024
Review comment:
This changes the default stack size
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] btashton commented on pull request #202: Make more the default stack size to DEFAULT_TASK_STACKSIZE
Posted by GitBox <gi...@apache.org>.
btashton commented on pull request #202:
URL: https://github.com/apache/incubator-nuttx-apps/pull/202#issuecomment-619406800
The failures look like this and I think it's because the two patches are dependent on each other. Now that we have the branch logic in for the releases, it will be fairly easy to add the PR linking logic, but I was waiting to get the release out first.
I would be fine merging the app side in now and then making sure the OS pr passes.
```
Building NuttX...
Normalize lc823450-xgevk/audio
file1: CONFIG_SYSTEM_USBMSC_CMD_STACKSIZE=2048
file2:
Saving the new configuration file
On branch master
Your branch is up to date with 'origin/master'.
Changes not staged for commit:
(use "git add <file>..." to update what will be committed)
(use "git checkout -- <file>..." to discard changes in working directory)
modified: boards/arm/lc823450/lc823450-xgevk/configs/audio/defconfig
no changes added to commit (use "git add" and/or "git commit -a")
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org