[GitHub] [rocketmq] RongtongJin commented on a diff in pull request #5879: [ISSUE #5883] fix: dledger commit log should override the getData

["RongtongJin (via GitHub)" <gi...@apache.org>]

RongtongJin commented on code in PR #5879:
URL: https://github.com/apache/rocketmq/pull/5879#discussion_r1118386090


##########
store/src/test/java/org/apache/rocketmq/store/timer/TimerMessageStoreTest.java:
##########
@@ -211,8 +220,31 @@ public Boolean call() {
         }
     }
 
+    @Test
+    public void testPutTimerMessage() throws Exception {
+        initStore(false);
+        testPutTimerMessageCommon();
+    }
+
+    @Test
+    public void testDledgerPutTimerMessage() throws Exception {
+        initStore(true);
+        testPutTimerMessageCommon();
+    }
+
     @Test
     public void testTimerFlowControl() throws Exception {
+        initStore(false);
+        testTimerFlowControlCommon();
+    }
+
+    @Test
+    public void testDledgerTimerFlowControl() throws Exception {
+        initStore(true);
+        testTimerFlowControlCommon();
+    }

Review Comment:
   > OK, I removed some of them.
   
   I suggest removing all tests temporarily and merge ASAP. Other PR can be subbmitted later to increase UTs.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org