[GitHub] [submarine] liuxunorg commented on a change in pull request #182: SUBMARINE-360. [WEB] Implement the frontend of sign-up page with Angular

[GitBox <gi...@apache.org>]

liuxunorg commented on a change in pull request #182: SUBMARINE-360. [WEB] Implement the frontend of sign-up page with Angular
URL: https://github.com/apache/submarine/pull/182#discussion_r377470297
 
 

 ##########
 File path: submarine-test/e2e/src/test/java/org/apache/submarine/integration/sidebarIT.java
 ##########
 @@ -66,7 +68,13 @@ public void sidebarNavigation() throws Exception {
     pollingWait(By.xpath("//span[contains(text(), \"Manager\")]"), MAX_BROWSER_TIMEOUT_SEC).click();
     pollingWait(By.xpath("//a[@href='/workbench/manager/user']"), MAX_BROWSER_TIMEOUT_SEC).click();
     SubmarineITUtils.sleep( 5000, true);
+
+    // Lazy-loading
+	  WebDriverWait wait = new WebDriverWait( driver, 15, 5000);
+	  pollingWait(By.xpath("//a[@href='/workbench/manager/user']"), MAX_BROWSER_TIMEOUT_SEC).click();  
+	  wait.until(ExpectedConditions.visibilityOfElementLocated(By.xpath("//span[@class='ant-breadcrumb-link ng-star-inserted']")));
 
 Review comment:
   Wrong code indentation

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@submarine.apache.org
For additional commands, e-mail: dev-help@submarine.apache.org