You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kudu.apache.org by da...@apache.org on 2018/03/05 20:34:42 UTC
[2/2] kudu git commit: Fix un-defined variable in push_to_asf.py
Fix un-defined variable in push_to_asf.py
Change-Id: I7b436033826171889b123fe90a2400f2494faf1f
Reviewed-on: http://gerrit.cloudera.org:8080/9495
Reviewed-by: Adar Dembo <ad...@cloudera.com>
Tested-by: Kudu Jenkins
Project: http://git-wip-us.apache.org/repos/asf/kudu/repo
Commit: http://git-wip-us.apache.org/repos/asf/kudu/commit/3bfcbd8a
Tree: http://git-wip-us.apache.org/repos/asf/kudu/tree/3bfcbd8a
Diff: http://git-wip-us.apache.org/repos/asf/kudu/diff/3bfcbd8a
Branch: refs/heads/master
Commit: 3bfcbd8ad27c9bd89fc72f2f6c49ee01f3382063
Parents: 249af9a
Author: Dan Burkert <da...@apache.org>
Authored: Mon Mar 5 11:40:44 2018 -0800
Committer: Dan Burkert <da...@apache.org>
Committed: Mon Mar 5 20:28:40 2018 +0000
----------------------------------------------------------------------
build-support/push_to_asf.py | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/kudu/blob/3bfcbd8a/build-support/push_to_asf.py
----------------------------------------------------------------------
diff --git a/build-support/push_to_asf.py b/build-support/push_to_asf.py
index f92a3b3..94e7cdb 100755
--- a/build-support/push_to_asf.py
+++ b/build-support/push_to_asf.py
@@ -43,6 +43,7 @@ import sys
from kudu_util import check_output, confirm_prompt, Colors, get_my_email
APACHE_REPO = "https://git-wip-us.apache.org/repos/asf/kudu.git"
+GERRIT_URL = "ssh://<username>@gerrit.cloudera.org:29418/kudu"
GERRIT_URL_RE = re.compile(r"ssh://.+@gerrit.cloudera.org:29418/kudu")
# ANSI color codes.
@@ -82,12 +83,12 @@ def check_gerrit_remote():
url = check_output(['git', 'config', '--local', '--get', 'remote.gerrit.url']).strip().decode('utf-8')
except subprocess.CalledProcessError:
print("No remote named 'gerrit'. Please set one up following ", file=sys.stderr)
- print("the contributor guide.", file=sys.stderr)
+ print("the contributor guide (git remote add gerrit %s)." % GERRIT_URL, file=sys.stderr)
sys.exit(1)
if not GERRIT_URL_RE.match(url):
print("Unexpected URL for remote 'gerrit'.", file=sys.stderr)
print(" Got: ", url, file=sys.stderr)
- print(" Expected to find host '%s' in the URL" % GERRIT_HOST, file=sys.stderr)
+ print(" Expected to find URL like '%s'" % GERRIT_URL, file=sys.stderr)
sys.exit(1)