You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@wicket.apache.org by Jeremy Thomerson <je...@wickettraining.com> on 2012/04/02 23:56:20 UTC
GitHub Pull Requests
After I saw the pull request below [1] I realized that our GitHub mirror
wasn't ever switched to pull from our Git@ASF repo. I requested that it be
changed. Jukka apparently updated it because it is now in sync.
This means future pull requests should automatically close themselves once
the commit hashes from the pull request appear in the requested branch.
[1] https://github.com/apache/wicket/pull/4
--
Jeremy Thomerson
http://wickettraining.com
*Need a CMS for Wicket? Use Brix! http://brixcms.org*
Re: GitHub Pull Requests
Posted by Martijn Dashorst <ma...@gmail.com>.
BTW AFIAK trivial stuff like a javadoc fix is always permitted through
a pull request.
As long as the contribution/patch is a couple of trivial code lines,
you can include it.
It becomes different when someone includes a package.html and complete
javadoc sections for classes and methods. That is not trivial.
Martijn
On Tue, Apr 3, 2012 at 11:06 AM, Martijn Dashorst
<ma...@gmail.com> wrote:
> I've asked the legal folks:
>
> http://markmail.org/message/3gvsg4qgc2khve27
>
> Martijn
>
> On Tue, Apr 3, 2012 at 9:16 AM, Martin Grigorov <mg...@apache.org> wrote:
>> Martijn,
>>
>> Can you confirm that by making a Pull Request at
>> https://github.com/apache/wicket the contributor is donating his code
>> according to ASF IP rules ? I.e. there is no reason for explicit ICLA
>> or checking radio button "This code is for ASF".
>>
>> On Tue, Apr 3, 2012 at 8:28 AM, Martin Grigorov <mg...@apache.org> wrote:
>>> For the record: https://issues.apache.org/jira/browse/INFRA-4635
>>>
>>> On Tue, Apr 3, 2012 at 1:20 AM, Igor Vaynberg <ig...@gmail.com> wrote:
>>>> also, a quick way to apply a pull request is to format it as a patch
>>>> and run it through git's mailbox support:
>>>>
>>>> curl https://github.com/apache/wicket/pull/4.patch | git am -s
>>>> (notice .patch appending to pull request url)
>>>>
>>>> -igor
>>>>
>>>> On Mon, Apr 2, 2012 at 2:56 PM, Jeremy Thomerson
>>>> <je...@wickettraining.com> wrote:
>>>>> After I saw the pull request below [1] I realized that our GitHub mirror
>>>>> wasn't ever switched to pull from our Git@ASF repo. I requested that it be
>>>>> changed. Jukka apparently updated it because it is now in sync.
>>>>>
>>>>> This means future pull requests should automatically close themselves once
>>>>> the commit hashes from the pull request appear in the requested branch.
>>>>>
>>>>> [1] https://github.com/apache/wicket/pull/4
>>>>>
>>>>> --
>>>>> Jeremy Thomerson
>>>>> http://wickettraining.com
>>>>> *Need a CMS for Wicket? Use Brix! http://brixcms.org*
>>>
>>>
>>>
>>> --
>>> Martin Grigorov
>>> jWeekend
>>> Training, Consulting, Development
>>> http://jWeekend.com
>>
>>
>>
>> --
>> Martin Grigorov
>> jWeekend
>> Training, Consulting, Development
>> http://jWeekend.com
>
>
>
> --
> Become a Wicket expert, learn from the best: http://wicketinaction.com
--
Become a Wicket expert, learn from the best: http://wicketinaction.com
Re: GitHub Pull Requests
Posted by Martijn Dashorst <ma...@gmail.com>.
I've asked the legal folks:
http://markmail.org/message/3gvsg4qgc2khve27
Martijn
On Tue, Apr 3, 2012 at 9:16 AM, Martin Grigorov <mg...@apache.org> wrote:
> Martijn,
>
> Can you confirm that by making a Pull Request at
> https://github.com/apache/wicket the contributor is donating his code
> according to ASF IP rules ? I.e. there is no reason for explicit ICLA
> or checking radio button "This code is for ASF".
>
> On Tue, Apr 3, 2012 at 8:28 AM, Martin Grigorov <mg...@apache.org> wrote:
>> For the record: https://issues.apache.org/jira/browse/INFRA-4635
>>
>> On Tue, Apr 3, 2012 at 1:20 AM, Igor Vaynberg <ig...@gmail.com> wrote:
>>> also, a quick way to apply a pull request is to format it as a patch
>>> and run it through git's mailbox support:
>>>
>>> curl https://github.com/apache/wicket/pull/4.patch | git am -s
>>> (notice .patch appending to pull request url)
>>>
>>> -igor
>>>
>>> On Mon, Apr 2, 2012 at 2:56 PM, Jeremy Thomerson
>>> <je...@wickettraining.com> wrote:
>>>> After I saw the pull request below [1] I realized that our GitHub mirror
>>>> wasn't ever switched to pull from our Git@ASF repo. I requested that it be
>>>> changed. Jukka apparently updated it because it is now in sync.
>>>>
>>>> This means future pull requests should automatically close themselves once
>>>> the commit hashes from the pull request appear in the requested branch.
>>>>
>>>> [1] https://github.com/apache/wicket/pull/4
>>>>
>>>> --
>>>> Jeremy Thomerson
>>>> http://wickettraining.com
>>>> *Need a CMS for Wicket? Use Brix! http://brixcms.org*
>>
>>
>>
>> --
>> Martin Grigorov
>> jWeekend
>> Training, Consulting, Development
>> http://jWeekend.com
>
>
>
> --
> Martin Grigorov
> jWeekend
> Training, Consulting, Development
> http://jWeekend.com
--
Become a Wicket expert, learn from the best: http://wicketinaction.com
Re: GitHub Pull Requests
Posted by Martin Grigorov <mg...@apache.org>.
Martijn,
Can you confirm that by making a Pull Request at
https://github.com/apache/wicket the contributor is donating his code
according to ASF IP rules ? I.e. there is no reason for explicit ICLA
or checking radio button "This code is for ASF".
On Tue, Apr 3, 2012 at 8:28 AM, Martin Grigorov <mg...@apache.org> wrote:
> For the record: https://issues.apache.org/jira/browse/INFRA-4635
>
> On Tue, Apr 3, 2012 at 1:20 AM, Igor Vaynberg <ig...@gmail.com> wrote:
>> also, a quick way to apply a pull request is to format it as a patch
>> and run it through git's mailbox support:
>>
>> curl https://github.com/apache/wicket/pull/4.patch | git am -s
>> (notice .patch appending to pull request url)
>>
>> -igor
>>
>> On Mon, Apr 2, 2012 at 2:56 PM, Jeremy Thomerson
>> <je...@wickettraining.com> wrote:
>>> After I saw the pull request below [1] I realized that our GitHub mirror
>>> wasn't ever switched to pull from our Git@ASF repo. I requested that it be
>>> changed. Jukka apparently updated it because it is now in sync.
>>>
>>> This means future pull requests should automatically close themselves once
>>> the commit hashes from the pull request appear in the requested branch.
>>>
>>> [1] https://github.com/apache/wicket/pull/4
>>>
>>> --
>>> Jeremy Thomerson
>>> http://wickettraining.com
>>> *Need a CMS for Wicket? Use Brix! http://brixcms.org*
>
>
>
> --
> Martin Grigorov
> jWeekend
> Training, Consulting, Development
> http://jWeekend.com
--
Martin Grigorov
jWeekend
Training, Consulting, Development
http://jWeekend.com
Re: GitHub Pull Requests
Posted by Martin Grigorov <mg...@apache.org>.
For the record: https://issues.apache.org/jira/browse/INFRA-4635
On Tue, Apr 3, 2012 at 1:20 AM, Igor Vaynberg <ig...@gmail.com> wrote:
> also, a quick way to apply a pull request is to format it as a patch
> and run it through git's mailbox support:
>
> curl https://github.com/apache/wicket/pull/4.patch | git am -s
> (notice .patch appending to pull request url)
>
> -igor
>
> On Mon, Apr 2, 2012 at 2:56 PM, Jeremy Thomerson
> <je...@wickettraining.com> wrote:
>> After I saw the pull request below [1] I realized that our GitHub mirror
>> wasn't ever switched to pull from our Git@ASF repo. I requested that it be
>> changed. Jukka apparently updated it because it is now in sync.
>>
>> This means future pull requests should automatically close themselves once
>> the commit hashes from the pull request appear in the requested branch.
>>
>> [1] https://github.com/apache/wicket/pull/4
>>
>> --
>> Jeremy Thomerson
>> http://wickettraining.com
>> *Need a CMS for Wicket? Use Brix! http://brixcms.org*
--
Martin Grigorov
jWeekend
Training, Consulting, Development
http://jWeekend.com
Re: GitHub Pull Requests
Posted by Igor Vaynberg <ig...@gmail.com>.
also, a quick way to apply a pull request is to format it as a patch
and run it through git's mailbox support:
curl https://github.com/apache/wicket/pull/4.patch | git am -s
(notice .patch appending to pull request url)
-igor
On Mon, Apr 2, 2012 at 2:56 PM, Jeremy Thomerson
<je...@wickettraining.com> wrote:
> After I saw the pull request below [1] I realized that our GitHub mirror
> wasn't ever switched to pull from our Git@ASF repo. I requested that it be
> changed. Jukka apparently updated it because it is now in sync.
>
> This means future pull requests should automatically close themselves once
> the commit hashes from the pull request appear in the requested branch.
>
> [1] https://github.com/apache/wicket/pull/4
>
> --
> Jeremy Thomerson
> http://wickettraining.com
> *Need a CMS for Wicket? Use Brix! http://brixcms.org*