You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by "jonathanc-n (via GitHub)" <gi...@apache.org> on 2024/11/27 05:14:43 UTC
[PR] docs: Add example to `hudi-datafusion` crate [hudi-rs]
jonathanc-n opened a new pull request, #202:
URL: https://github.com/apache/hudi-rs/pull/202
## Description
<!--- Describe your changes in detail -->
Added the example from the README to the `hudi-datafusion` crate to `HudiDataSource` and `HudiTableFactory`
<!--- If it fixes an open issue, please link to the issue here. -->
<!--- Please link any related issues and PRs as well. -->
## How are the changes test-covered
- [ ] N/A
- [ ] Automated tests (unit and/or integration tests)
- [ ] Manual tests
- [ ] Details are described below
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] docs: add example to `hudi-datafusion` crate [hudi-rs]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #202:
URL: https://github.com/apache/hudi-rs/pull/202#issuecomment-2503079125
## [Codecov](https://app.codecov.io/gh/apache/hudi-rs/pull/202?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
All modified and coverable lines are covered by tests :white_check_mark:
> Project coverage is 91.78%. Comparing base [(`361e281`)](https://app.codecov.io/gh/apache/hudi-rs/commit/361e281666422fb7e9d87eca2e3723beece6faaf?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`c8b2ae9`)](https://app.codecov.io/gh/apache/hudi-rs/commit/c8b2ae9a049cd2be91c876a7c4d30873a8cc97f8?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## main #202 +/- ##
=======================================
Coverage 91.78% 91.78%
=======================================
Files 20 20
Lines 962 962
=======================================
Hits 883 883
Misses 79 79
```
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/hudi-rs/pull/202?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] docs: Add example to `hudi-datafusion` crate [hudi-rs]
Posted by "xushiyan (via GitHub)" <gi...@apache.org>.
xushiyan commented on code in PR #202:
URL: https://github.com/apache/hudi-rs/pull/202#discussion_r1859998825
##########
crates/datafusion/src/lib.rs:
##########
@@ -105,7 +135,6 @@ impl TableProvider for HudiDataSource {
let file_slices = self
.table
- // TODO: implement supports_filters_pushdown() to pass filters to Hudi table API
Review Comment:
revert this? irrelevant change
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] docs: Add example to `hudi-datafusion` crate [hudi-rs]
Posted by "jonathanc-n (via GitHub)" <gi...@apache.org>.
jonathanc-n commented on code in PR #202:
URL: https://github.com/apache/hudi-rs/pull/202#discussion_r1860002206
##########
crates/datafusion/src/lib.rs:
##########
@@ -105,7 +135,6 @@ impl TableProvider for HudiDataSource {
let file_slices = self
.table
- // TODO: implement supports_filters_pushdown() to pass filters to Hudi table API
Review Comment:
reverted
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] docs: Add example to `hudi-datafusion` crate [hudi-rs]
Posted by "jonathanc-n (via GitHub)" <gi...@apache.org>.
jonathanc-n commented on PR #202:
URL: https://github.com/apache/hudi-rs/pull/202#issuecomment-2502959925
@xushiyan resolved conflict
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] docs: add example to `hudi-datafusion` crate [hudi-rs]
Posted by "xushiyan (via GitHub)" <gi...@apache.org>.
xushiyan merged PR #202:
URL: https://github.com/apache/hudi-rs/pull/202
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org