You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/06/14 15:11:17 UTC

[GitHub] [incubator-nuttx] patacongo commented on a change in pull request #1233: [DRAFT] Add support to CDC-MBIM USB host driver

patacongo commented on a change in pull request #1233:
URL: https://github.com/apache/incubator-nuttx/pull/1233#discussion_r439839343



##########
File path: include/nuttx/usb/cdc.h
##########
@@ -890,15 +930,15 @@ struct cdc_linecoding_s
 struct cdc_linestatus_s
 {
   uint8_t size[2];   /* wLength, Size of this structure, in bytes */
-  uint8_t ringer[4]; /* dwRingerBitmap, Ringer Configuration bitmap for this line */
+  uint8_t ringer[4]; /* dwRingerBitmap, Ringer Conf bitmap for this line */

Review comment:
       ```suggestion
     uint8_t ringer[4]; /* dwRingerBitmap, Ringer Configuration bitmap for this
                                 * line */
   ```
   
   Conf is not an acceptable abbreviation for anything.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org