You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2021/06/18 21:20:01 UTC
[GitHub] [cloudstack] ravening opened a new pull request #5132: Change logrotate interval to hourly
ravening opened a new pull request #5132:
URL: https://github.com/apache/cloudstack/pull/5132
### Description
Fixes #5117
The logrotate config says interval as hourly but it relies
on timer service to be invoked but in timer the frequency
is mentioned as 12h. So it wont be invoked every hour.
So change the frequency to hourly
<!--- Describe your changes in DETAIL - And how has behaviour functionally changed. -->
<!-- For new features, provide link to FS, dev ML discussion etc. -->
<!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. -->
<!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged -->
<!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
<!-- Fixes: # -->
<!--- ********************************************************************************* -->
<!--- NOTE: AUTOMATATION USES THE DESCRIPTIONS TO SET LABELS AND PRODUCE DOCUMENTATION. -->
<!--- PLEASE PUT AN 'X' in only **ONE** box -->
<!--- ********************************************************************************* -->
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [X] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
### Feature/Enhancement Scale or Bug Severity
#### Feature/Enhancement Scale
- [ ] Major
- [X] Minor
#### Bug Severity
- [ ] BLOCKER
- [X] Critical
- [ ] Major
- [ ] Minor
- [ ] Trivial
### Screenshots (if appropriate):
### How Has This Been Tested?
<!-- Please describe in detail how you tested your changes. -->
<!-- Include details of your testing environment, and the tests you ran to -->
<!-- see how your change affects other areas of the code, etc. -->
<!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md) document -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache edited a comment on pull request #5132: Change logrotate interval to hourly
Posted by GitBox <gi...@apache.org>.
weizhouapache edited a comment on pull request #5132:
URL: https://github.com/apache/cloudstack/pull/5132#issuecomment-881278286
@ravening this works in my testing
```
root@r-84-VM:~# systemctl status logrotate.timer
● logrotate.timer - Daily rotation of log files
Loaded: loaded (/lib/systemd/system/logrotate.timer; enabled; vendor preset: enabled)
Active: active (waiting) since Thu 2021-07-15 13:25:51 UTC; 18h ago
Trigger: Fri 2021-07-16 08:00:00 UTC; 5min left
Triggers: ● logrotate.service
Docs: man:logrotate(8)
man:logrotate.conf(5)
Jul 15 13:25:51 systemvm systemd[1]: Started Daily rotation of log files.
root@r-84-VM:~# systemctl status logrotate.timer
● logrotate.timer - Daily rotation of log files
Loaded: loaded (/lib/systemd/system/logrotate.timer; enabled; vendor preset: enabled)
Active: active (waiting) since Thu 2021-07-15 13:25:51 UTC; 19h ago
Trigger: Fri 2021-07-16 09:00:00 UTC; 23min left
Triggers: ● logrotate.service
Docs: man:logrotate(8)
man:logrotate.conf(5)
Jul 15 13:25:51 systemvm systemd[1]: Started Daily rotation of log files.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #5132: Change logrotate interval to hourly
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on pull request #5132:
URL: https://github.com/apache/cloudstack/pull/5132#issuecomment-865991360
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd merged pull request #5132: Change logrotate interval to hourly
Posted by GitBox <gi...@apache.org>.
rhtyd merged pull request #5132:
URL: https://github.com/apache/cloudstack/pull/5132
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #5132: Change logrotate interval to hourly
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on pull request #5132:
URL: https://github.com/apache/cloudstack/pull/5132#issuecomment-866038977
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] ravening commented on pull request #5132: Change logrotate interval to hourly
Posted by GitBox <gi...@apache.org>.
ravening commented on pull request #5132:
URL: https://github.com/apache/cloudstack/pull/5132#issuecomment-870345447
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] ravening commented on pull request #5132: Change logrotate interval to hourly
Posted by GitBox <gi...@apache.org>.
ravening commented on pull request #5132:
URL: https://github.com/apache/cloudstack/pull/5132#issuecomment-870345447
@weizhouapache @rhtyd is there a plan to build new systemvm image using this fix and make it available to public?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache closed pull request #5132: Change logrotate interval to hourly
Posted by GitBox <gi...@apache.org>.
weizhouapache closed pull request #5132:
URL: https://github.com/apache/cloudstack/pull/5132
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5132: Change logrotate interval to hourly
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5132:
URL: https://github.com/apache/cloudstack/pull/5132#issuecomment-866453681
<b>Trillian test result (tid-1040)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 37471 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5132-t1040-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_affinity_groups_projects.py
Intermittent failure detected: /marvin/tests/smoke/test_affinity_groups.py
Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_clusters.py
Intermittent failure detected: /marvin/tests/smoke/test_routers_network_ops.py
Intermittent failure detected: /marvin/tests/smoke/test_hostha_kvm.py
Smoke tests completed. 83 look OK, 4 have error(s)
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_DeployVmAntiAffinityGroup_in_project | `Error` | 69.18 | test_affinity_groups_projects.py
test_DeployVmAntiAffinityGroup | `Error` | 37.55 | test_affinity_groups.py
test_03_deploy_and_scale_kubernetes_cluster | `Failure` | 23.59 | test_kubernetes_clusters.py
test_07_deploy_kubernetes_ha_cluster | `Failure` | 0.04 | test_kubernetes_clusters.py
test_08_deploy_and_upgrade_kubernetes_ha_cluster | `Failure` | 0.04 | test_kubernetes_clusters.py
test_09_delete_kubernetes_ha_cluster | `Failure` | 0.04 | test_kubernetes_clusters.py
test_hostha_kvm_host_degraded | `Failure` | 685.38 | test_hostha_kvm.py
test_hostha_kvm_host_fencing | `Failure` | 644.76 | test_hostha_kvm.py
test_hostha_kvm_host_recovering | `Failure` | 641.72 | test_hostha_kvm.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #5132: Change logrotate interval to hourly
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on pull request #5132:
URL: https://github.com/apache/cloudstack/pull/5132#issuecomment-872231042
@ravening
In my opinion, logrotate.timer needs to be restarted or reloaded after config changes.
please test it and create a new pr if needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #5132: Change logrotate interval to hourly
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on pull request #5132:
URL: https://github.com/apache/cloudstack/pull/5132#issuecomment-864989204
@ravening could you fix vpcrouter as well ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #5132: Change logrotate interval to hourly
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #5132:
URL: https://github.com/apache/cloudstack/pull/5132#issuecomment-864821687
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5132: Change logrotate interval to hourly
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5132:
URL: https://github.com/apache/cloudstack/pull/5132#issuecomment-865235351
<b>Trillian test result (tid-1025)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 33895 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5132-t1025-kvm-centos7.zip
Smoke tests completed. 87 look OK, 0 have error(s)
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5132: Change logrotate interval to hourly
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5132:
URL: https://github.com/apache/cloudstack/pull/5132#issuecomment-864822714
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #5132: Change logrotate interval to hourly
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #5132:
URL: https://github.com/apache/cloudstack/pull/5132#issuecomment-864821687
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #5132: Change logrotate interval to hourly
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #5132:
URL: https://github.com/apache/cloudstack/pull/5132#issuecomment-865646427
@weizhouapache @ravening will we wait with merging for a similar solution for vpcrouter.sh?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5132: Change logrotate interval to hourly
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5132:
URL: https://github.com/apache/cloudstack/pull/5132#issuecomment-866035260
Packaging result: :heavy_check_mark: centos7 :heavy_check_mark: centos8 :heavy_check_mark: debian. SL-JID 322
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] ravening commented on pull request #5132: Change logrotate interval to hourly
Posted by GitBox <gi...@apache.org>.
ravening commented on pull request #5132:
URL: https://github.com/apache/cloudstack/pull/5132#issuecomment-865687242
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache closed pull request #5132: Change logrotate interval to hourly
Posted by GitBox <gi...@apache.org>.
weizhouapache closed pull request #5132:
URL: https://github.com/apache/cloudstack/pull/5132
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #5132: Change logrotate interval to hourly
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #5132:
URL: https://github.com/apache/cloudstack/pull/5132#issuecomment-865646427
@weizhouapache @ravening will we wait with merging for a similar solution for vpcrouter.sh?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5132: Change logrotate interval to hourly
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5132:
URL: https://github.com/apache/cloudstack/pull/5132#issuecomment-865991797
@weizhouapache a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5132: Change logrotate interval to hourly
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5132:
URL: https://github.com/apache/cloudstack/pull/5132#issuecomment-864138883
Packaging result: :heavy_check_mark: centos7 :heavy_check_mark: centos8 :heavy_check_mark: debian. SL-JID 298
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #5132: Change logrotate interval to hourly
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on pull request #5132:
URL: https://github.com/apache/cloudstack/pull/5132#issuecomment-864989204
@ravening could you fix vpcrouter as well ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5132: Change logrotate interval to hourly
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5132:
URL: https://github.com/apache/cloudstack/pull/5132#issuecomment-866039347
@weizhouapache a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] ravening commented on pull request #5132: Change logrotate interval to hourly
Posted by GitBox <gi...@apache.org>.
ravening commented on pull request #5132:
URL: https://github.com/apache/cloudstack/pull/5132#issuecomment-870353980
> > @weizhouapache @rhtyd is there a plan to build new systemvm image using this fix and make it available to public?
>
> @ravening this change does not require new systemvm template.
@weizhouapache If a new routervm is deployed, it wont get this change right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #5132: Change logrotate interval to hourly
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on pull request #5132:
URL: https://github.com/apache/cloudstack/pull/5132#issuecomment-870350554
> @weizhouapache @rhtyd is there a plan to build new systemvm image using this fix and make it available to public?
@ravening this change does not require new systemvm template.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5132: Change logrotate interval to hourly
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5132:
URL: https://github.com/apache/cloudstack/pull/5132#issuecomment-864822714
@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #5132: Change logrotate interval to hourly
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on pull request #5132:
URL: https://github.com/apache/cloudstack/pull/5132#issuecomment-881278286
@ravening this works in my testing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #5132: Change logrotate interval to hourly
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on pull request #5132:
URL: https://github.com/apache/cloudstack/pull/5132#issuecomment-870350554
> @weizhouapache @rhtyd is there a plan to build new systemvm image using this fix and make it available to public?
@ravening this change does not require new systemvm template.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org