You are viewing a plain text version of this content. The canonical link for it is here.
Posted to pr@jena.apache.org by GitBox <gi...@apache.org> on 2020/01/31 20:52:32 UTC

[GitHub] [jena] acoburn opened a new pull request #684: JENA-1833: Add jena-commonsrdf to jena-osgi

acoburn opened a new pull request #684: JENA-1833: Add jena-commonsrdf to jena-osgi
URL: https://github.com/apache/jena/pull/684
 
 
   This adds the commonsrdf project to the jena-osgi bundle
   
   Tested with Karaf 4.2.6

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For additional commands, e-mail: pr-help@jena.apache.org

[GitHub] [jena] afs commented on issue #684: JENA-1833: Add jena-commonsrdf to jena-osgi

Posted by GitBox <gi...@apache.org>.
afs commented on issue #684: JENA-1833: Add jena-commonsrdf to jena-osgi
URL: https://github.com/apache/jena/pull/684#issuecomment-581162053
 
 
   I am encountering a problem with this.
   
   mvn: 3.6.3
   
   The commons-rdf-api:tests artifact does not have a version and the commons-rdf-simple artifact has `${ver.commonsrdf}`. These seem to be needed in /pom.xml.
   
         <dependency>
           <groupId>org.apache.commons</groupId>
           <artifactId>commons-rdf-api</artifactId>
           <version>${ver.commonsrdf}</version>
           <classifier>tests</classifier>
         </dependency>
   
         <dependency>
           <groupId>org.apache.commons</groupId>
           <artifactId>commons-rdf-simple</artifactId>
           <version>${ver.commonsrdf}</version>
         </dependency>
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For additional commands, e-mail: pr-help@jena.apache.org

[GitHub] [jena] acoburn commented on issue #684: JENA-1833: Add jena-commonsrdf to jena-osgi

Posted by GitBox <gi...@apache.org>.
acoburn commented on issue #684: JENA-1833: Add jena-commonsrdf to jena-osgi
URL: https://github.com/apache/jena/pull/684#issuecomment-581565915
 
 
   Thanks for the feedback. This PR should now be in line with your suggestions.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For additional commands, e-mail: pr-help@jena.apache.org

[GitHub] [jena] acoburn commented on issue #684: JENA-1833: Add jena-commonsrdf to jena-osgi

Posted by GitBox <gi...@apache.org>.
acoburn commented on issue #684: JENA-1833: Add jena-commonsrdf to jena-osgi
URL: https://github.com/apache/jena/pull/684#issuecomment-581175716
 
 
   Interesting. I thought the `dependencyManagement` would have taken care of this, but I've adjusted the PR to be more explicit about the commons rdf dependencies

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For additional commands, e-mail: pr-help@jena.apache.org

[GitHub] [jena] afs commented on issue #684: JENA-1833: Add jena-commonsrdf to jena-osgi

Posted by GitBox <gi...@apache.org>.
afs commented on issue #684: JENA-1833: Add jena-commonsrdf to jena-osgi
URL: https://github.com/apache/jena/pull/684#issuecomment-581331053
 
 
   It is `<scope>test` items causing build problems. The default scope dependencyManagement works fine. 
   
   This is the set of changes mentioned in the review:
   [jena1833-afs.txt](https://github.com/apache/jena/files/4147238/jena1833-afs.txt)
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For additional commands, e-mail: pr-help@jena.apache.org

[GitHub] [jena] afs commented on a change in pull request #684: JENA-1833: Add jena-commonsrdf to jena-osgi

Posted by GitBox <gi...@apache.org>.
afs commented on a change in pull request #684: JENA-1833: Add jena-commonsrdf to jena-osgi
URL: https://github.com/apache/jena/pull/684#discussion_r374012926
 
 

 ##########
 File path: pom.xml
 ##########
 @@ -575,12 +575,6 @@
         <version>${ver.commonscli}</version>
       </dependency>
 
-      <dependency>
 
 Review comment:
   This worked for the default scope artifact.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For additional commands, e-mail: pr-help@jena.apache.org

[GitHub] [jena] acoburn commented on issue #684: JENA-1833: Add jena-commonsrdf to jena-osgi

Posted by GitBox <gi...@apache.org>.
acoburn commented on issue #684: JENA-1833: Add jena-commonsrdf to jena-osgi
URL: https://github.com/apache/jena/pull/684#issuecomment-581216184
 
 
   Does that [last commit](https://github.com/apache/jena/pull/684/commits/737a6e0800cf102ac087ee81df8123dcff5d9fb0) work for you? I upgraded to maven 3.6.3 locally, and it builds for me.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For additional commands, e-mail: pr-help@jena.apache.org

[GitHub] [jena] acoburn merged pull request #684: JENA-1833: Add jena-commonsrdf to jena-osgi

Posted by GitBox <gi...@apache.org>.
acoburn merged pull request #684: JENA-1833: Add jena-commonsrdf to jena-osgi
URL: https://github.com/apache/jena/pull/684
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For additional commands, e-mail: pr-help@jena.apache.org

[GitHub] [jena] afs commented on issue #684: JENA-1833: Add jena-commonsrdf to jena-osgi

Posted by GitBox <gi...@apache.org>.
afs commented on issue #684: JENA-1833: Add jena-commonsrdf to jena-osgi
URL: https://github.com/apache/jena/pull/684#issuecomment-581184950
 
 
   I should have been clearer - the build problem I'm getting is in the jena-commonsrdf module. Didn't get to jena-osgi because jena-commonsrdf didn't build. The explicit versions shouldn't be necessary. 
   
   The real problem is the commons-rdf-api:tests. The "simple" issue is a red herring.
   
   It seems that defining in the dependencyManagement of the parent for the main artifact does not apply to `<classifier>test` -- this may be related to being in `<scope>test`.
   
   In jena-commonsrdf/pom.xml:
   
       <dependency>
         <groupId>org.apache.commons</groupId>
         <artifactId>commons-rdf-api</artifactId>
         <version>${ver.commonsrdf}</version>
         <classifier>tests</classifier>
       </dependency>
   
   works and, to me, looks tidier than in the root /pom.xml.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For additional commands, e-mail: pr-help@jena.apache.org

[GitHub] [jena] afs commented on a change in pull request #684: JENA-1833: Add jena-commonsrdf to jena-osgi

Posted by GitBox <gi...@apache.org>.
afs commented on a change in pull request #684: JENA-1833: Add jena-commonsrdf to jena-osgi
URL: https://github.com/apache/jena/pull/684#discussion_r374011769
 
 

 ##########
 File path: apache-jena-osgi/jena-osgi/pom.xml
 ##########
 @@ -232,6 +239,11 @@
       <groupId>org.apache.commons</groupId>
       <artifactId>commons-lang3</artifactId>
     </dependency>
+    <dependency>
+      <groupId>org.apache.commons</groupId>
+      <artifactId>commons-rdf-api</artifactId>
+      <version>${ver.commonsrdf}</version>
 
 Review comment:
   Not needed. Picking up from the parent POM worked for this one.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For additional commands, e-mail: pr-help@jena.apache.org

[GitHub] [jena] afs edited a comment on issue #684: JENA-1833: Add jena-commonsrdf to jena-osgi

Posted by GitBox <gi...@apache.org>.
afs edited a comment on issue #684: JENA-1833: Add jena-commonsrdf to jena-osgi
URL: https://github.com/apache/jena/pull/684#issuecomment-581331053
 
 
   It is `<scope>test` items causing build problems. The default scope dependencyManagement works fine. 
   
   This is the set of changes after the items in the review:
   [jena1833-afs.txt](https://github.com/apache/jena/files/4147238/jena1833-afs.txt)
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For additional commands, e-mail: pr-help@jena.apache.org