You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Jie Yu <yu...@gmail.com> on 2016/11/30 20:31:41 UTC

Review Request 54226: Exposed IOSwitchboard to MesosContainerizer.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54226/
-----------------------------------------------------------

Review request for mesos and Kevin Klues.


Bugs: MESOS-6651
    https://issues.apache.org/jira/browse/MESOS-6651


Repository: mesos


Description
-------

Exposed IOSwitchboard to MesosContainerizer.


Diffs
-----

  src/slave/containerizer/mesos/containerizer.hpp 370a26686c62c973b3e9c06c4653b7657719c858 
  src/slave/containerizer/mesos/containerizer.cpp 7dde6fc7c20ecd3543891e7d33230d0eaf9460a2 
  src/slave/containerizer/mesos/io/switchboard.hpp d3ab52d98ade067ccec63f3539073c152840099f 
  src/slave/containerizer/mesos/io/switchboard.cpp ae7a1fe3e24d5dc18269d9da951493700ee957d0 

Diff: https://reviews.apache.org/r/54226/diff/


Testing
-------

make check


Thanks,

Jie Yu


Re: Review Request 54226: Exposed IOSwitchboard to MesosContainerizer.

Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54226/#review157497
-----------------------------------------------------------



Patch looks great!

Reviews applied: [54226]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On Nov. 30, 2016, 8:31 p.m., Jie Yu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54226/
> -----------------------------------------------------------
> 
> (Updated Nov. 30, 2016, 8:31 p.m.)
> 
> 
> Review request for mesos and Kevin Klues.
> 
> 
> Bugs: MESOS-6651
>     https://issues.apache.org/jira/browse/MESOS-6651
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Exposed IOSwitchboard to MesosContainerizer.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/containerizer.hpp 370a26686c62c973b3e9c06c4653b7657719c858 
>   src/slave/containerizer/mesos/containerizer.cpp 7dde6fc7c20ecd3543891e7d33230d0eaf9460a2 
>   src/slave/containerizer/mesos/io/switchboard.hpp d3ab52d98ade067ccec63f3539073c152840099f 
>   src/slave/containerizer/mesos/io/switchboard.cpp ae7a1fe3e24d5dc18269d9da951493700ee957d0 
> 
> Diff: https://reviews.apache.org/r/54226/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>


Re: Review Request 54226: Exposed IOSwitchboard to MesosContainerizer.

Posted by Kevin Klues <kl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54226/#review157462
-----------------------------------------------------------


Ship it!




Ship It!

- Kevin Klues


On Nov. 30, 2016, 8:31 p.m., Jie Yu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54226/
> -----------------------------------------------------------
> 
> (Updated Nov. 30, 2016, 8:31 p.m.)
> 
> 
> Review request for mesos and Kevin Klues.
> 
> 
> Bugs: MESOS-6651
>     https://issues.apache.org/jira/browse/MESOS-6651
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Exposed IOSwitchboard to MesosContainerizer.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/containerizer.hpp 370a26686c62c973b3e9c06c4653b7657719c858 
>   src/slave/containerizer/mesos/containerizer.cpp 7dde6fc7c20ecd3543891e7d33230d0eaf9460a2 
>   src/slave/containerizer/mesos/io/switchboard.hpp d3ab52d98ade067ccec63f3539073c152840099f 
>   src/slave/containerizer/mesos/io/switchboard.cpp ae7a1fe3e24d5dc18269d9da951493700ee957d0 
> 
> Diff: https://reviews.apache.org/r/54226/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>