You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-dev@hadoop.apache.org by "Hadoop QA (JIRA)" <ji...@apache.org> on 2008/04/16 00:48:21 UTC

[jira] Commented: (HADOOP-3127) rm /user//.Trash/____ only moves it back to .Trash

    [ https://issues.apache.org/jira/browse/HADOOP-3127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12589269#action_12589269 ] 

Hadoop QA commented on HADOOP-3127:
-----------------------------------

+1 overall.  Here are the results of testing the latest attachment 
http://issues.apache.org/jira/secure/attachment/12380175/fixInTrashDeletion.patch
against trunk revision 645773.

    @author +1.  The patch does not contain any @author tags.

    tests included +1.  The patch appears to include 3 new or modified tests.

    javadoc +1.  The javadoc tool did not generate any warning messages.

    javac +1.  The applied patch does not generate any new javac compiler warnings.

    release audit +1.  The applied patch does not generate any new release audit warnings.

    findbugs +1.  The patch does not introduce any new Findbugs warnings.

    core tests +1.  The patch passed core unit tests.

    contrib tests +1.  The patch passed contrib unit tests.

Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2242/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2242/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2242/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2242/console

This message is automatically generated.

> rm /user/<username>/.Trash/____ only moves it back to .Trash 
> -------------------------------------------------------------
>
>                 Key: HADOOP-3127
>                 URL: https://issues.apache.org/jira/browse/HADOOP-3127
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: fs
>    Affects Versions: 0.16.2, 0.16.3, 0.17.0, 0.18.0
>            Reporter: Koji Noguchi
>            Priority: Minor
>         Attachments: fixInTrashDeletion.patch
>
>
> In 0.15 or before, any dfs -rm call for  files under Trash were deleted. 
> From 0.16, it just renames it back to Trash.
> In Trash.java:moveToTrash() 
> {noformat}
> if (path.toString().startsWith(trash.toString()))
> {noformat}
> seems like trash.toString() is fully qualified, and path.toString() is not.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.