You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by GitBox <gi...@apache.org> on 2021/10/21 11:28:06 UTC

[GitHub] [zeppelin] Reamer opened a new pull request #4261: [ZEPPELIN-5571] Return empty list instead of null

Reamer opened a new pull request #4261:
URL: https://github.com/apache/zeppelin/pull/4261


   ### What is this PR for?
   This pull request sends an empty list to the zeppelin-web-angular frontend and the variable `settings` is defined with it.
   
   
   ### What type of PR is it?
    - Bug Fix
   
   ### What is the Jira issue?
   * https://issues.apache.org/jira/browse/ZEPPELIN-5571
   
   ### How should this be tested?
   * Ci
   
   ### Questions:
   * Does the licenses files need update? No
   * Is there breaking changes for older versions? No
   * Does this needs documentation? No
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [zeppelin] asfgit closed pull request #4261: [ZEPPELIN-5571] Return empty list instead of null

Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #4261:
URL: https://github.com/apache/zeppelin/pull/4261


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [zeppelin] Reamer commented on pull request #4261: [ZEPPELIN-5571] Return empty list instead of null

Posted by GitBox <gi...@apache.org>.
Reamer commented on pull request #4261:
URL: https://github.com/apache/zeppelin/pull/4261#issuecomment-948582883


   Because this is a small pull request without much change, I would merge this into master and branch-0.10 on Friday as long as no further comments come in.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [zeppelin] zjffdu commented on a change in pull request #4261: [ZEPPELIN-5571] Return empty list instead of null

Posted by GitBox <gi...@apache.org>.
zjffdu commented on a change in pull request #4261:
URL: https://github.com/apache/zeppelin/pull/4261#discussion_r733591377



##########
File path: zeppelin-plugins/notebookrepo/filesystem/src/main/java/org/apache/zeppelin/notebook/repo/OldFileSystemNotebookRepo.java
##########
@@ -81,7 +82,7 @@ public void close() {
   @Override
   public List<NotebookRepoSettingsInfo> getSettings(AuthenticationInfo subject) {
     LOGGER.warn("getSettings is not implemented for HdfsNotebookRepo");
-    return null;
+    return Collections.emptyList();

Review comment:
       Not related to this PR, I think it is time to move these Old NotebookRepo 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [zeppelin] Reamer commented on a change in pull request #4261: [ZEPPELIN-5571] Return empty list instead of null

Posted by GitBox <gi...@apache.org>.
Reamer commented on a change in pull request #4261:
URL: https://github.com/apache/zeppelin/pull/4261#discussion_r733604406



##########
File path: zeppelin-plugins/notebookrepo/filesystem/src/main/java/org/apache/zeppelin/notebook/repo/OldFileSystemNotebookRepo.java
##########
@@ -81,7 +82,7 @@ public void close() {
   @Override
   public List<NotebookRepoSettingsInfo> getSettings(AuthenticationInfo subject) {
     LOGGER.warn("getSettings is not implemented for HdfsNotebookRepo");
-    return null;
+    return Collections.emptyList();

Review comment:
       Did you mean "remove" instead of "move"?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [zeppelin] zjffdu commented on pull request #4261: [ZEPPELIN-5571] Return empty list instead of null

Posted by GitBox <gi...@apache.org>.
zjffdu commented on pull request #4261:
URL: https://github.com/apache/zeppelin/pull/4261#issuecomment-949250677


   LGTM


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [zeppelin] 1Elle1111 commented on pull request #4261: [ZEPPELIN-5571] Return empty list instead of null

Posted by GitBox <gi...@apache.org>.
1Elle1111 commented on pull request #4261:
URL: https://github.com/apache/zeppelin/pull/4261#issuecomment-949265237


   Merge?
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [zeppelin] zjffdu commented on a change in pull request #4261: [ZEPPELIN-5571] Return empty list instead of null

Posted by GitBox <gi...@apache.org>.
zjffdu commented on a change in pull request #4261:
URL: https://github.com/apache/zeppelin/pull/4261#discussion_r733608397



##########
File path: zeppelin-plugins/notebookrepo/filesystem/src/main/java/org/apache/zeppelin/notebook/repo/OldFileSystemNotebookRepo.java
##########
@@ -81,7 +82,7 @@ public void close() {
   @Override
   public List<NotebookRepoSettingsInfo> getSettings(AuthenticationInfo subject) {
     LOGGER.warn("getSettings is not implemented for HdfsNotebookRepo");
-    return null;
+    return Collections.emptyList();

Review comment:
       I mean "remove"




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org