You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@pekko.apache.org by "pjfanning (via GitHub)" <gi...@apache.org> on 2023/07/04 20:23:26 UTC
[GitHub] [incubator-pekko-sbt-paradox] pjfanning opened a new pull request, #64: ignore local build files
pjfanning opened a new pull request, #64:
URL: https://github.com/apache/incubator-pekko-sbt-paradox/pull/64
* sbt-source-dist plugin uses .gitignore to decide which local files to leave out of the source dist
* these dirs are ending up in the source dist for this repo and they contain local path stuff that shouldn't really be in the source dist
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-sbt-paradox] pjfanning commented on pull request #64: ignore local build files
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on PR #64:
URL: https://github.com/apache/incubator-pekko-sbt-paradox/pull/64#issuecomment-1620730870
sbt-source-dist only uses the .gitignore from the git repo and not the personal .gitignore of the user
is it ok to do a temporary sbt-source-dist solution and some back to https://github.com/pjfanning/sbt-source-dist/issues/14 in a few weeks
I was trying to get a incubator-pekko-sbt-paradox RC started but it is now blocked because of the .idea and .bsp files adding files to the zip/tgz.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-sbt-paradox] pjfanning closed pull request #64: ignore local build files
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning closed pull request #64: ignore local build files
URL: https://github.com/apache/incubator-pekko-sbt-paradox/pull/64
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-sbt-paradox] pjfanning commented on pull request #64: ignore local build files
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on PR #64:
URL: https://github.com/apache/incubator-pekko-sbt-paradox/pull/64#issuecomment-1620725824
The only alternative is to hardcode ignore files into sbt-source-dist - I can set that up
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-sbt-paradox] mdedetrich commented on pull request #64: ignore local build files
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on PR #64:
URL: https://github.com/apache/incubator-pekko-sbt-paradox/pull/64#issuecomment-1620732104
Yeah I get the problem now, I think best solution would be to hardcode these extra paths within sbt-source-dist logic directly along with a comment pointing to https://github.com/pjfanning/sbt-source-dist/issues/14 as the proper solution to implement later. To me this solution seems better rather than having to update the `.gitignore` for all of our pekko repos in a non ideal way.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-sbt-paradox] mdedetrich commented on pull request #64: ignore local build files
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on PR #64:
URL: https://github.com/apache/incubator-pekko-sbt-paradox/pull/64#issuecomment-1620726688
> The only alternative is to hardcode ignore files into sbt-source-dist - I can set that up
So is the central problem that sbt-source-dist isn't respecting a global `.gitignore` which means that IDE specific paths in the global `.gitignore` are unintentionally getting picked up in the source package?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-sbt-paradox] pjfanning commented on pull request #64: ignore local build files
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on PR #64:
URL: https://github.com/apache/incubator-pekko-sbt-paradox/pull/64#issuecomment-1620733419
I raised https://github.com/pjfanning/sbt-source-dist/pull/28 as a short term fix
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-sbt-paradox] pjfanning commented on pull request #64: ignore local build files
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on PR #64:
URL: https://github.com/apache/incubator-pekko-sbt-paradox/pull/64#issuecomment-1620712353
It's just how the current plugin code works. We want to ignore some of the files and since .gitignore exists, it seemed like a useful set of files to ignore. The incubator-pekko one already ignores these, so that's why they weren't a problem with that build - see https://github.com/apache/incubator-pekko/blob/main/.gitignore
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-sbt-paradox] mdedetrich commented on pull request #64: ignore local build files
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on PR #64:
URL: https://github.com/apache/incubator-pekko-sbt-paradox/pull/64#issuecomment-1620707683
Im kind of confused, how are the paths in the root `.gitignore` effecting what the plugin does?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-sbt-paradox] mdedetrich commented on pull request #64: ignore local build files
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on PR #64:
URL: https://github.com/apache/incubator-pekko-sbt-paradox/pull/64#issuecomment-1620724030
Oh woops, I accidentally thought this repo sbt-source-dist. I don't entirely agree with this change and thats because its actually considered bad practice to add IDE/editor specific files to `.gitignore`, the following are all good articles on the matter
* https://dev.to/oleksiyrudenko/please-do-not-pollute-projects-gitignore-3h8e
* https://tekin.co.uk/2020/03/maintain-a-global-git-ignore-file
For example, if we are going to add `.idea` why don't we then add `.vscode` (a lot of people including myself use vscode for Scala projects), or `*~` for vim? Or what about `.DS_Store` for MacOS? https://github.com/apache/incubator-pekko/blob/main/.gitignore is actually a very good example of exactly why not to do this, that `.gitignore` file is atrociously large and needs to be pruned a bit.
Ultimately IDE/Editor files/folders have nothing to do with the project, its a personal preference which means that the standard way to add IDE/editor specific files/folders is by using a [global gitignore](https://stackoverflow.com/questions/7335420/global-git-ignore).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org