You are viewing a plain text version of this content. The canonical link for it is here.
Posted to solr-commits@lucene.apache.org by ry...@apache.org on 2008/12/18 23:40:30 UTC
svn commit: r727847 -
/lucene/solr/trunk/src/java/org/apache/solr/core/SolrCore.java
Author: ryan
Date: Thu Dec 18 14:40:30 2008
New Revision: 727847
URL: http://svn.apache.org/viewvc?rev=727847&view=rev
Log:
SOLR-930 -- log error close is already closed
Modified:
lucene/solr/trunk/src/java/org/apache/solr/core/SolrCore.java
Modified: lucene/solr/trunk/src/java/org/apache/solr/core/SolrCore.java
URL: http://svn.apache.org/viewvc/lucene/solr/trunk/src/java/org/apache/solr/core/SolrCore.java?rev=727847&r1=727846&r2=727847&view=diff
==============================================================================
--- lucene/solr/trunk/src/java/org/apache/solr/core/SolrCore.java (original)
+++ lucene/solr/trunk/src/java/org/apache/solr/core/SolrCore.java Thu Dec 18 14:40:30 2008
@@ -694,10 +694,12 @@
*/
public void close() {
int count = refCount.decrementAndGet();
- if (count > 0) return;
+ if (count > 0){
+ log.warn( "Attempted close on {} did not succeed because the new reference count {} is > 0. ", this, count );
+ return;
+ }
if (count < 0) {
- //throw new RuntimeException("Too many closes on " + this);
- log.error("Too many close {count:"+count+"} on " + this + ". Please report this exception to solr-user@lucene.apache.org");
+ log.error("Too many close [count:{}] on {}. Please report this exception to solr-user@lucene.apache.org", count, this );
return;
}
log.info(logid+" CLOSING SolrCore " + this);