[jira] Commented: (SHINDIG-383) unit tests for io.js

["Kevin Brown (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SHINDIG-383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12605388#action_12605388 ] 

Kevin Brown commented on SHINDIG-383:
-------------------------------------

- Converting gadgets.io into a constructor is painful (like all constructors in javascript); it doesn't add anything to the tests since gadgets.io.makeRequest works the same as it always has. Using a constructor is far more expensive at run time than simply defining properties on an object.  None of the tests are deriving any benefit out of this, so what value does it add? For a long explanation of this, try Doug Crockford's book "Javascript: the good parts".

- Tests for getProxyUrl need to include %rawurl% as well as %url%

- This doesn't test the IE6 case (window.ActiveXObject). 


> unit tests for io.js
> --------------------
>
>                 Key: SHINDIG-383
>                 URL: https://issues.apache.org/jira/browse/SHINDIG-383
>             Project: Shindig
>          Issue Type: Bug
>          Components: Features (Javascript)
>            Reporter: Brian Eaton
>         Attachments: iotest.patch
>
>
> We should have unittests for io.js.  I've put together a (very rough) patch for that based on a mocked out XMLHTTPRequest object.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.