[GitHub] [avro] subhashb opened a new pull request #1166: AVRO-3097: Run Schema Compatibility checks as part of Unittest

[GitBox <gi...@apache.org>]

subhashb opened a new pull request #1166:
URL: https://github.com/apache/avro/pull/1166


   AVRO-3097: Run Schema Compatibility checks as part of Unittest
       
   Test methods in `test_compatibility.py` were being ignored in unittest runs because they were not connected to `unittest.TestCase`.
   
   This PR encloses the test cases within a class deriving from `unittest.TestCase` and also changes assert statements to be in compliance with unittest. It also exposes `compatibility` as a module in the `avro` package.
   
   Make sure you have checked _all_ steps below.
   
   ### Jira
   
   - [x] My PR addresses the following [Avro Jira](https://issues.apache.org/jira/browse/AVRO/) issues and references them in the PR title. For example, "AVRO-1234: My Avro PR"
     - https://issues.apache.org/jira/browse/AVRO-3097
   
   ### Tests
   
   - [x] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
     Reuses existing tests but folds them within `unittest` so that they run as part of regular build runs.
   
   ### Commits
   
   - [x] My commits all reference Jira issues in their subject lines. In addition, my commits follow the guidelines from "[How to write a good git commit message](https://chris.beams.io/posts/git-commit/)":
     1. Subject is separated from body by a blank line
     1. Subject is limited to 50 characters (not including Jira issue reference)
     1. Subject does not end with a period
     1. Subject uses the imperative mood ("add", not "adding")
     1. Body wraps at 72 characters
     1. Body explains "what" and "why", not "how"
   
   ### Documentation
   
   - [x] In case of new functionality, my PR adds documentation that describes how to use it.
     **NA**
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [avro] kojiromike merged pull request #1166: AVRO-3097: Run Schema Compatibility checks as part of Unittest

[GitBox <gi...@apache.org>]

kojiromike merged pull request #1166:
URL: https://github.com/apache/avro/pull/1166


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org