You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Jan Schlicht <ja...@mesosphere.io> on 2017/10/18 13:50:21 UTC
Re: Review Request 61810: Added a function to apply offer operations.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61810/
-----------------------------------------------------------
(Updated Oct. 18, 2017, 3:50 p.m.)
Review request for mesos, Benjamin Bannier and Jie Yu.
Changes
-------
Rebased on top of #63001.
Bugs: MESOS-7594
https://issues.apache.org/jira/browse/MESOS-7594
Repository: mesos
Description
-------
The resource provider manager provides an 'apply' function for offer
operation affecting resource providers. The resource on which the
operation should be applied contains a resource provider ID. This will
be extracted and an event will be sent to the respective resource
provider.
Diffs (updated)
-----
src/resource_provider/manager.hpp 3b70e75c6b6721864ae0ee9c4a593b5035d8388f
src/resource_provider/manager.cpp 31fcb789f5ab907511e868c374c49f7457a33ed3
src/tests/resource_provider_manager_tests.cpp ca49e1f0203494fc8b4a4507c33e5a3885a14a59
Diff: https://reviews.apache.org/r/61810/diff/2/
Changes: https://reviews.apache.org/r/61810/diff/1-2/
Testing
-------
make check
Thanks,
Jan Schlicht
Re: Review Request 61810: Added a function to apply offer operations.
Posted by Chun-Hung Hsiao <ch...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61810/#review189504
-----------------------------------------------------------
src/resource_provider/manager.cpp
Lines 315 (patched)
<https://reviews.apache.org/r/61810/#comment266607>
Currently `protobuf::getConsumedResources()` only accepts `CREATE_VOLUME`, `DESTROY_VOLUME`, `CREATE_BLOCK`, and `DESTROY_BLOCK`. I think Jie's idea is that we still pass `RESERVE`, `UNRESERVE`, `CREATE` and `DESTROY` into the resource provider and ask the resource provider to checkpoint the information there, and avoid another checkpoint in the agent to simplify reconciliation.
src/resource_provider/manager.cpp
Lines 319 (patched)
<https://reviews.apache.org/r/61810/#comment266608>
If we only handle volume and block creation and destruction here, this loop is not required since the operations contain only a single resource. If we want to also pass in reservation and persistent volume operations, do we require the framework to send individual operations for each resource provider, or do we want to accept one single `CREATE` that contains resources from multiple providers, and do the multiplexing here?
The publish function I'm working on takes the latter approach.
- Chun-Hung Hsiao
On Oct. 20, 2017, 12:51 p.m., Jan Schlicht wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61810/
> -----------------------------------------------------------
>
> (Updated Oct. 20, 2017, 12:51 p.m.)
>
>
> Review request for mesos, Benjamin Bannier and Jie Yu.
>
>
> Bugs: MESOS-7594
> https://issues.apache.org/jira/browse/MESOS-7594
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The resource provider manager provides an 'apply' function for offer
> operation affecting resource providers. The resource on which the
> operation should be applied contains a resource provider ID. This will
> be extracted and an event will be sent to the respective resource
> provider.
>
>
> Diffs
> -----
>
> src/resource_provider/manager.hpp 3b70e75c6b6721864ae0ee9c4a593b5035d8388f
> src/resource_provider/manager.cpp 31fcb789f5ab907511e868c374c49f7457a33ed3
> src/tests/resource_provider_manager_tests.cpp ca49e1f0203494fc8b4a4507c33e5a3885a14a59
>
>
> Diff: https://reviews.apache.org/r/61810/diff/3/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jan Schlicht
>
>
Re: Review Request 61810: Added a function to apply offer operations.
Posted by Jan Schlicht <ja...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61810/
-----------------------------------------------------------
(Updated Oct. 20, 2017, 2:51 p.m.)
Review request for mesos, Benjamin Bannier and Jie Yu.
Changes
-------
Rebased, changed logging behavior to include operation id.
Bugs: MESOS-7594
https://issues.apache.org/jira/browse/MESOS-7594
Repository: mesos
Description
-------
The resource provider manager provides an 'apply' function for offer
operation affecting resource providers. The resource on which the
operation should be applied contains a resource provider ID. This will
be extracted and an event will be sent to the respective resource
provider.
Diffs (updated)
-----
src/resource_provider/manager.hpp 3b70e75c6b6721864ae0ee9c4a593b5035d8388f
src/resource_provider/manager.cpp 31fcb789f5ab907511e868c374c49f7457a33ed3
src/tests/resource_provider_manager_tests.cpp ca49e1f0203494fc8b4a4507c33e5a3885a14a59
Diff: https://reviews.apache.org/r/61810/diff/3/
Changes: https://reviews.apache.org/r/61810/diff/2-3/
Testing
-------
make check
Thanks,
Jan Schlicht