[GitHub] flink issue #3720: [FLINK-6302] Documentation build error on ruby 2.4

[alpinegizmo <gi...@git.apache.org>]

Github user alpinegizmo commented on the issue:

    https://github.com/apache/flink/pull/3720
  
    I prefer a conservative approach for as long as we still have to support building the docs on Ruby 1.9, so I'd keep the number of updated gems as small as possible.
    
    As for adding support for Ruby 2.4, both docs/Gemfile and docs/ruby2/Gemfile should be updated, along with their corresponding (and derived) Gemfile.lock files. Moreover, the octokit downgrade is not needed. 
    
    I'm not sure what motivates some of the proposed gem upgrades. I was able to get the docs to build on ruby 2.4 by making changing both Gemfiles as shown below. This leaves the classifier-reborn, ffi, libv8, posix-spawn, rb-inotify, redcarpet, and sass gems as they are rather than upgrading them. Do we need newer versions of any of those?
    
    -gem 'json'
    +gem 'json', '2.0.4'
    +gem 'yajl-ruby', '1.2.2'
    +gem 'jekyll-coffeescript', '1.0.2'
    
    With these upgrades, the build script still works for me on Ruby 1.9.3 and 2.3.3, as well as 2.4.0.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---