You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/08/18 06:55:04 UTC

[GitHub] [airflow] uranusjr edited a comment on pull request #17654: Only call `task_runner.return_code` from `LocalTaskJob._execute`

uranusjr edited a comment on pull request #17654:
URL: https://github.com/apache/airflow/pull/17654#issuecomment-900837843


   > I think that if we end a runner without it heartbeating, we should explicitly use SIGKILL
   
   Hmm, that makes sense as well. I don’t have a strong opinion either way (this is basically the programmatic equivalent of “what counts as life”).
   
   It seems like @ashb added that line (623d5cdaff17ac2e909df0fe86120897310d4314) so maybe he’d have some thoughts.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org