[GitHub] [zookeeper] eolivelli commented on a diff in pull request #1961: ZOOKEEPER-4571: Admin server API for restore database from a snapshot

[GitBox <gi...@apache.org>]

eolivelli commented on code in PR #1961:
URL: https://github.com/apache/zookeeper/pull/1961#discussion_r1064790569


##########
zookeeper-server/src/main/java/org/apache/zookeeper/server/ZooKeeperServer.java:
##########
@@ -1151,6 +1213,9 @@ protected void setLocalSessionFlag(Request si) {
     }
 
     public void submitRequest(Request si) {
+        if (state == State.MAINTENANCE) {
+            throw new IllegalStateException("Zookeeper server is in maintenance state");
+        }

Review Comment:
   blocking here is probably not a good idea, we risk to block the pipeline, with unpredictable consequences probably



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@zookeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org