You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by "runningcode (via GitHub)" <gi...@apache.org> on 2023/05/15 16:22:23 UTC

[GitHub] [lucene] runningcode opened a new pull request, #12293: Capture build scans on ge.apache.org to benefit from deep build insights

runningcode opened a new pull request, #12293:
URL: https://github.com/apache/lucene/pull/12293

   Description
   This PR publishes a build scan for every CI build on Jenkins and GitHub Actions and for every local build from an authenticated Apache committer. The build will not fail if publishing fails.
   
   The build scans of the Apache Lucene project are published to the Gradle Enterprise instance at [ge.apache.org](https://ge.apache.org/), hosted by the Apache Software Foundation and run in partnership between the ASF and Gradle. This Gradle Enterprise instance has all features and extensions enabled and is freely available for use by the Apache Lucene project and all other Apache projects.
   
   This pull request enhances the functionality of publishing build scans to the publicly available [scans.gradle.com](https://scans.gradle.com/) by instead publishing build scans to [ge.apache.org](https://ge.apache.org/). On this Gradle Enterprise instance, Apache Lucene will have access not only to all of the published build scans but other aggregate data features such as:
   
   Dashboards to view all historical build scans, along with performance trends over time
   Build failure analytics for enhanced investigation and diagnosis of build failures
   Test failure analytics to better understand trends and causes around slow, failing, and flaky tests
   If interested in exploring a fully populated Gradle Enterprise instance, please explore the builds already connected to [ge.apache.org](https://ge.apache.org/), the [Spring project’s instance](https://ge.spring.io/scans?search.relativeStartTime=P28D&search.timeZoneId=Europe/Zurich), or any number of other [OSS projects](https://gradle.com/enterprise-customers/oss-projects/) for which we sponsor instances of Gradle Enterprise.
   
   Please let me know if there are any questions about the value of Gradle Enterprise or the changes in this pull request and I’d be happy to address them.
   
   This PR supersedes https://github.com/apache/lucene/pull/12266


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org


[GitHub] [lucene] clayburn commented on pull request #12293: Capture build scans on ge.apache.org to benefit from deep build insights

Posted by "clayburn (via GitHub)" <gi...@apache.org>.
clayburn commented on PR #12293:
URL: https://github.com/apache/lucene/pull/12293#issuecomment-1578800452

   > This looks good to me, for what it's worth. Thank you. It'd be great to move to a newer gradle version but I sense it won't be easy - there are some hacks we need and use that probably won't fly with newer gradle revisions. Still the effort here would be very much appreciated if you have the time and will to help out!
   
   @dweiss thanks for the feedback. The build scans can help out here with the migration to newer Gradle versions. In particular the [deprecations](https://ge.apache.org/s/bgnup7sek4lgc/deprecations) view can give you a good sense of what needs to be updated before moving to a new Gradle version.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org


[GitHub] [lucene] uschindler commented on a diff in pull request #12293: Capture build scans on ge.apache.org to benefit from deep build insights

Posted by "uschindler (via GitHub)" <gi...@apache.org>.
uschindler commented on code in PR #12293:
URL: https://github.com/apache/lucene/pull/12293#discussion_r1200427420


##########
gradle/ge.gradle:
##########
@@ -0,0 +1,26 @@
+def isGithubActions = System.getenv('GITHUB_ACTIONS') != null
+def isJenkins = System.getenv('JENKINS_URL') != null
+def isCI = isGithubActions || isJenkins

Review Comment:
   we already have a global variable to detect CI builds:
   https://github.com/apache/lucene/blob/8a602b5063d2154bf1ffa7ddb2a13a313cd954e0/gradle/globals.gradle#L153-L156



##########
gradle/ge.gradle:
##########
@@ -0,0 +1,26 @@
+def isGithubActions = System.getenv('GITHUB_ACTIONS') != null
+def isJenkins = System.getenv('JENKINS_URL') != null
+def isCI = isGithubActions || isJenkins
+
+gradleEnterprise {
+    server = "https://ge.apache.org"
+    buildScan {
+        capture { taskInputFiles = true }
+        uploadInBackground = !isCI
+        publishAlways()
+        publishIfAuthenticated()
+        obfuscation {
+            ipAddresses { addresses -> addresses.collect { address -> "0.0.0.0"} }
+        }
+    }
+}
+
+buildCache {

Review Comment:
   There are strong objections to enable the build cache of Gradle. It is explicitely disabled in our properties files.
   
   So please remove that!



##########
gradle/ge.gradle:
##########
@@ -0,0 +1,26 @@
+def isGithubActions = System.getenv('GITHUB_ACTIONS') != null
+def isJenkins = System.getenv('JENKINS_URL') != null
+def isCI = isGithubActions || isJenkins
+
+gradleEnterprise {
+    server = "https://ge.apache.org"

Review Comment:
   We also have Jenkins servers outside of Apache's infra. Those should not use this plugin!? I don't know if those have access.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org


[GitHub] [lucene] clayburn commented on a diff in pull request #12293: Capture build scans on ge.apache.org to benefit from deep build insights

Posted by "clayburn (via GitHub)" <gi...@apache.org>.
clayburn commented on code in PR #12293:
URL: https://github.com/apache/lucene/pull/12293#discussion_r1204072698


##########
gradle/ge.gradle:
##########
@@ -0,0 +1,26 @@
+def isGithubActions = System.getenv('GITHUB_ACTIONS') != null
+def isJenkins = System.getenv('JENKINS_URL') != null
+def isCI = isGithubActions || isJenkins
+
+gradleEnterprise {
+    server = "https://ge.apache.org"
+    buildScan {
+        capture { taskInputFiles = true }
+        uploadInBackground = !isCI
+        publishAlways()
+        publishIfAuthenticated()
+        obfuscation {
+            ipAddresses { addresses -> addresses.collect { address -> "0.0.0.0"} }
+        }
+    }
+}
+
+buildCache {

Review Comment:
   Thanks for the feedback. One thing you may be interested in, released with Gradle 8, is the ability to have more control over the cleanup intervals of various Gradle caches: https://docs.gradle.org/8.0/userguide/directory_layout.html#dir:gradle_user_home:configure_cache_cleanup
   
   For now, I made no changes though, since you by default have caching disabled globally. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org


Re: [PR] Capture build scans on ge.apache.org to benefit from deep build insights [lucene]

Posted by "dsmiley (via GitHub)" <gi...@apache.org>.
dsmiley commented on PR #12293:
URL: https://github.com/apache/lucene/pull/12293#issuecomment-1777343300

   @clayburn An espoused benefit to this PR is that, as an Apache committer, I could do builds on my own machine and have the analysis be published for viewing on ge.apache.org.  How do I do that?
   
   One of the things I am most excited about from the Gradle Enterprise integration is the possibility of parallel test runners to select a set of tests that is better balanced based on the expected execution time of each test.  Today, there is a long-tail of reduced machine utilization towards the end of the overall test run as fewer and fewer parallel test runners are still busy running tests.  This is much more pronounced in Solr than Lucene.  At ASF Community-over-Code while speaking to the Develocity folks, I heard running builds locally (albeit connected to GE as with this PR), result in GE picking the test distribution based on stored knowledge GE has of previous build runs.  Do I have this right?  Presumably this would also work for CI builds?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org


[GitHub] [lucene] clayburn commented on pull request #12293: Capture build scans on ge.apache.org to benefit from deep build insights

Posted by "clayburn (via GitHub)" <gi...@apache.org>.
clayburn commented on PR #12293:
URL: https://github.com/apache/lucene/pull/12293#issuecomment-1564550262

   > Is there a solution for 3rd party build Servers not having any CI secret.
   
   > I am fine with the changes (mostly), except.
   
   > Also please make it conditionally when running on 3rd party build Servers. An idea would be no use the JENKINS_URL with a regex on "apache.org".
   
   @uschindler - This is handled by the `publishIfAuthenticated` setting. For a 3rd party CI server (or an unathenticated local user), no publishing occurs. You can see what this looks like by just running a build on this branch without authenticating to https://ge.apache.org. The behavior when unauthenticated essentially becomes a no-op.
   
   I have another change incoming to add the license header to `ge.gradle` to fix that check.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org


[GitHub] [lucene] dweiss commented on pull request #12293: Capture build scans on ge.apache.org to benefit from deep build insights

Posted by "dweiss (via GitHub)" <gi...@apache.org>.
dweiss commented on PR #12293:
URL: https://github.com/apache/lucene/pull/12293#issuecomment-1573274154

   This looks good to me, for what it's worth. Thank you. It'd be great to move to a newer gradle version but I sense it won't be easy - there are some hacks we need and use that probably won't fly with newer gradle revisions. Still the effort here would be very much appreciated if you have the time and will to help out!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org


[GitHub] [lucene] clayburn commented on a diff in pull request #12293: Capture build scans on ge.apache.org to benefit from deep build insights

Posted by "clayburn (via GitHub)" <gi...@apache.org>.
clayburn commented on code in PR #12293:
URL: https://github.com/apache/lucene/pull/12293#discussion_r1204066867


##########
gradle/ge.gradle:
##########
@@ -0,0 +1,26 @@
+def isGithubActions = System.getenv('GITHUB_ACTIONS') != null
+def isJenkins = System.getenv('JENKINS_URL') != null
+def isCI = isGithubActions || isJenkins
+
+gradleEnterprise {
+    server = "https://ge.apache.org"

Review Comment:
   I've matched the the isCIBuild check here to watch you have in globals.gradle.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org


[GitHub] [lucene] clayburn commented on a diff in pull request #12293: Capture build scans on ge.apache.org to benefit from deep build insights

Posted by "clayburn (via GitHub)" <gi...@apache.org>.
clayburn commented on code in PR #12293:
URL: https://github.com/apache/lucene/pull/12293#discussion_r1200451756


##########
gradle/ge.gradle:
##########
@@ -0,0 +1,26 @@
+def isGithubActions = System.getenv('GITHUB_ACTIONS') != null
+def isJenkins = System.getenv('JENKINS_URL') != null
+def isCI = isGithubActions || isJenkins
+
+gradleEnterprise {
+    server = "https://ge.apache.org"

Review Comment:
   This is a good question. Those other Jenkins instances would need access tokens in order to publish build scans to ge.apache.org. Without the token, the `publishIfAuthenticated` setting will cause the build not to publish, so this PR would not cause any harm in the meantime.
   
   Let me follow up on the question of the access key with the infrastructure team.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org


[GitHub] [lucene] uschindler commented on pull request #12293: Capture build scans on ge.apache.org to benefit from deep build insights

Posted by "uschindler (via GitHub)" <gi...@apache.org>.
uschindler commented on PR #12293:
URL: https://github.com/apache/lucene/pull/12293#issuecomment-1564543093

   I am fine with the changes (mostly), but I still don't understand why this needs to be on top-top level and can't be inside the `gradle/` subfolder.
   
   Also please make it conditionally when running on 3rd party build Servers. An idea would be no use the JENKINS_URL with a regex on "apache.org".


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org


[GitHub] [lucene] clayburn commented on a diff in pull request #12293: Capture build scans on ge.apache.org to benefit from deep build insights

Posted by "clayburn (via GitHub)" <gi...@apache.org>.
clayburn commented on code in PR #12293:
URL: https://github.com/apache/lucene/pull/12293#discussion_r1200469331


##########
gradle/ge.gradle:
##########
@@ -0,0 +1,26 @@
+def isGithubActions = System.getenv('GITHUB_ACTIONS') != null
+def isJenkins = System.getenv('JENKINS_URL') != null
+def isCI = isGithubActions || isJenkins
+
+gradleEnterprise {
+    server = "https://ge.apache.org"
+    buildScan {
+        capture { taskInputFiles = true }
+        uploadInBackground = !isCI
+        publishAlways()
+        publishIfAuthenticated()
+        obfuscation {
+            ipAddresses { addresses -> addresses.collect { address -> "0.0.0.0"} }
+        }
+    }
+}
+
+buildCache {

Review Comment:
   This configuration will only be applied if your build sets `org.gradle.caching=true`. As the Lucene build works today, you do not set this, so caching as a feature will be globally disabled. If a user enables caching, then this configuration would be applied. I'd recommend leaving this so that these settings get applied when users do enable the global caching property.
   
   Aside from that, what is the objection to using build caching? Is it due to disk space considerations as stated in the gradle properties template?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org


Re: [PR] Capture build scans on ge.apache.org to benefit from deep build insights [lucene]

Posted by "clayburn (via GitHub)" <gi...@apache.org>.
clayburn commented on PR #12293:
URL: https://github.com/apache/lucene/pull/12293#issuecomment-1777496879

   @dsmiley - Excellent questions:
   
   > An espoused benefit to this PR is that, as an Apache committer, I could do builds on my own machine and have the analysis be published for viewing on ge.apache.org. How do I do that?
   
   You can do this by logging into ge.apache.org using your Apache LDAP credentials and creating an access key. The easiest way to do this is via the [Automated access key provisioning](https://docs.gradle.com/enterprise/gradle-plugin/#authenticating).
   
   > One of the things I am most excited about from the Gradle Enterprise integration is the possibility of parallel test runners to select a set of tests that is better balanced based on the expected execution time of each test. Today, there is a long-tail of reduced machine utilization towards the end of the overall test run as fewer and fewer parallel test runners are still busy running tests. This is much more pronounced in Solr than Lucene. At ASF Community-over-Code while speaking to the Develocity folks, I heard running builds locally (albeit connected to GE as with this PR), result in GE picking the test distribution based on stored knowledge GE has of previous build runs. 
   
   This is somewhat true. This is not a default behavior and will not be enabled by this PR. But there absolutely is a mechanism to do this using Test Distribution, and we'd be happy to submit a follow up PR to enable this (both here and to Solr).
   
   > Do I have this right? 
   
   Yes, the ASF instance is fully featured.
   
   > Presumably this would also work for CI builds?
   
   Yes


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org


Re: [PR] Capture build scans on ge.apache.org to benefit from deep build insights [lucene]

Posted by "dsmiley (via GitHub)" <gi...@apache.org>.
dsmiley commented on PR #12293:
URL: https://github.com/apache/lucene/pull/12293#issuecomment-1777598613

   Here's [my build I ran locally](https://ge.apache.org/s/nsaeazuf3tkcu/timeline) for anyone who is interested.  I observe that Lucene tests seem well balanced (judging from the cool timeline view), so I wouldn't prioritize that test balancing feature here.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org


Re: [PR] Capture build scans on ge.apache.org to benefit from deep build insights [lucene]

Posted by "dsmiley (via GitHub)" <gi...@apache.org>.
dsmiley merged PR #12293:
URL: https://github.com/apache/lucene/pull/12293


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org


[GitHub] [lucene] uschindler commented on a diff in pull request #12293: Capture build scans on ge.apache.org to benefit from deep build insights

Posted by "uschindler (via GitHub)" <gi...@apache.org>.
uschindler commented on code in PR #12293:
URL: https://github.com/apache/lucene/pull/12293#discussion_r1200514470


##########
gradle/ge.gradle:
##########
@@ -0,0 +1,26 @@
+def isGithubActions = System.getenv('GITHUB_ACTIONS') != null
+def isJenkins = System.getenv('JENKINS_URL') != null
+def isCI = isGithubActions || isJenkins
+
+gradleEnterprise {
+    server = "https://ge.apache.org"
+    buildScan {
+        capture { taskInputFiles = true }
+        uploadInBackground = !isCI
+        publishAlways()
+        publishIfAuthenticated()
+        obfuscation {
+            ipAddresses { addresses -> addresses.collect { address -> "0.0.0.0"} }
+        }
+    }
+}
+
+buildCache {

Review Comment:
   OK Thanks!
   
   To answer your question. On private workstations it should be kept disabled as it has some drawbacks:
   
   When it was enabled I needed to "rm -rf ~/.gradle/" almost daily in my homedir to get rid of tons of files. This was espeically a desaster when the Gradle build was "under development". There are also some people that disable the gradle daemon, because at same time their whole "ps" was filled with unused daemons (those people often run tests with different versions of JDK and all of them spawn separate sets of processes).
   
   At some point Gradle should clean up its caches correctly and sometimes delete old stuff, which seems not working at moment.
   
   The same by the way happened on above "Policeman Jenkins", it filled its Jenkins homedir with cached stuff and dies several times and due to gradle daemons for hundreds of Java versions it also filled its memory.
   
   I agree on coorporate environments it can be enabled, but people working from different parts of the world on a open source projects, over exxcessive caching stops progress. I have no problem with Gradle taking 2 secs longer on startup.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org


[GitHub] [lucene] uschindler commented on a diff in pull request #12293: Capture build scans on ge.apache.org to benefit from deep build insights

Posted by "uschindler (via GitHub)" <gi...@apache.org>.
uschindler commented on code in PR #12293:
URL: https://github.com/apache/lucene/pull/12293#discussion_r1200504015


##########
gradle/ge.gradle:
##########
@@ -0,0 +1,26 @@
+def isGithubActions = System.getenv('GITHUB_ACTIONS') != null
+def isJenkins = System.getenv('JENKINS_URL') != null
+def isCI = isGithubActions || isJenkins
+
+gradleEnterprise {
+    server = "https://ge.apache.org"

Review Comment:
   Maybe just improve the check and use a regex on the JENKINS_URL to figure out we run on correct server and only enable it there.
   
   It is important that the build does not fail in "other" CI environments, because there are many environments where Lucene code is built as our large quality framework: Elastic, Opensearch, Policeman Jenkins (JDK variant and Garbage Collector testing),.... They should not need a key. So lets's maybe only enable it for Jenkins of ASF. 
   
   Github CI is only to validate Pull requests, it is also not needed there.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org


Re: [PR] Capture build scans on ge.apache.org to benefit from deep build insights [lucene]

Posted by "risdenk (via GitHub)" <gi...@apache.org>.
risdenk commented on PR #12293:
URL: https://github.com/apache/lucene/pull/12293#issuecomment-1775322129

   @dsmiley I mentioned this on the Solr PR for the same change - https://github.com/apache/solr/pull/1626#issuecomment-1553288366
   
   https://ci-builds.apache.org/job/Lucene/job/Lucene-Check-main/10504/ links to https://ge.apache.org/s/d4zsyldjcntga
   
   So you can see what this looks like today without this PR.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org


Re: [PR] Capture build scans on ge.apache.org to benefit from deep build insights [lucene]

Posted by "clayburn (via GitHub)" <gi...@apache.org>.
clayburn commented on PR #12293:
URL: https://github.com/apache/lucene/pull/12293#issuecomment-1753607350

   @dsmiley - Here is the PR we were discussing at Community Over Code


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org


Re: [PR] Capture build scans on ge.apache.org to benefit from deep build insights [lucene]

Posted by "dsmiley (via GitHub)" <gi...@apache.org>.
dsmiley commented on PR #12293:
URL: https://github.com/apache/lucene/pull/12293#issuecomment-1773459815

   I'm eager to see the kind of build insights Gradle Enterprise offers us.  If there are no further concerns, I'll merge Tuesday.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org