You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "zhengruifeng (via GitHub)" <gi...@apache.org> on 2023/10/04 11:16:05 UTC
[PR] [SPARK-45412][PYTHON][CONNECT] Validate the plan and session in `DataFrame.__init__` [spark]
zhengruifeng opened a new pull request, #43215:
URL: https://github.com/apache/spark/pull/43215
### What changes were proposed in this pull request?
Validate the plan and session in `DataFrame.__init__`
### Why are the changes needed?
- many dataframe APIs validate the plan and session, but throw different exceptions: `SparkConnectException`, `Exception`, `PySparkValueError`, `AssertionError`.
- there are still some method haven't validate the plan and session
### Does this PR introduce _any_ user-facing change?
yes, the exceptions are unified
### How was this patch tested?
ci
### Was this patch authored or co-authored using generative AI tooling?
no
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-45412][PYTHON][CONNECT] Validate the plan and session in `DataFrame.__init__` [spark]
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on PR #43215:
URL: https://github.com/apache/spark/pull/43215#issuecomment-1747849066
Merged to master.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-45412][PYTHON][CONNECT] Validate the plan and session in `DataFrame.__init__` [spark]
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon closed pull request #43215: [SPARK-45412][PYTHON][CONNECT] Validate the plan and session in `DataFrame.__init__`
URL: https://github.com/apache/spark/pull/43215
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org