You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by rxin <gi...@git.apache.org> on 2016/10/21 01:30:52 UTC

[GitHub] spark pull request #15513: [SPARK-17963][SQL][Documentation] Add examples (e...

Github user rxin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/15513#discussion_r84406275
  
    --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/command/DDLSuite.scala ---
    @@ -1455,50 +1455,62 @@ class DDLSuite extends QueryTest with SharedSQLContext with BeforeAndAfterEach {
           sql("DESCRIBE FUNCTION log"),
           Row("Class: org.apache.spark.sql.catalyst.expressions.Logarithm") ::
             Row("Function: log") ::
    -        Row("Usage: log(b, x) - Returns the logarithm of x with base b.") :: Nil
    +        Row("Usage: log(expr1, expr2) - Returns the logarithm of expr1 with base expr2.") :: Nil
    --- End diff --
    
    i think the old b, x are actually more clearer ...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org